Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: extensions/shell/browser/shell_content_browser_client.cc

Issue 1071173002: Use command line to signal whether a child process was passed V8 snapshot files via file descriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8_ext_cast
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/browser/shell_content_browser_client.cc
diff --git a/extensions/shell/browser/shell_content_browser_client.cc b/extensions/shell/browser/shell_content_browser_client.cc
index 3971f0ca86683b7def20bf56af7d9f6047ea9091..8d998b8d27be467392598558e93e5db75087cce6 100644
--- a/extensions/shell/browser/shell_content_browser_client.cc
+++ b/extensions/shell/browser/shell_content_browser_client.cc
@@ -203,6 +203,16 @@ void ShellContentBrowserClient::AppendExtraCommandLineSwitches(
int child_process_id) {
std::string process_type =
command_line->GetSwitchValueASCII(::switches::kProcessType);
+
+#if defined(OS_POSIX) && !defined(OS_MACOSX)
+#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
+ if (process_type != switches::kZygoteProcess) {
+ command_line->AppendSwitch(::switches::kV8NativesPassedByFD);
+ command_line->AppendSwitch(::switches::kV8SnapshotPassedByFD);
+ }
+#endif // V8_USE_EXTERNAL_STARTUP_DATA
+#endif // OS_POSIX && !OS_MACOSX
+
if (process_type == ::switches::kRendererProcess)
AppendRendererSwitches(command_line);
}

Powered by Google App Engine
This is Rietveld 408576698