content/shell/browser/shell_content_browser_client.cc - Issue 1071173002: Use command line to signal whether a child process was passed V8 snapshot files via file descriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_content_browser_client.cc

Issue 1071173002: Use command line to signal whether a child process was passed V8 snapshot files via file descriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8_ext_cast

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/content_switches.cc ('K') | « content/public/common/content_switches.cc ('k') | extensions/shell/browser/shell_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_content_browser_client.cc

diff --git a/content/shell/browser/shell_content_browser_client.cc b/content/shell/browser/shell_content_browser_client.cc

index 07d114815364f37b1753121ed4a049c523b676a0..fc03843c0830ae4aa60860821fa40fd451bf1523 100644

--- a/content/shell/browser/shell_content_browser_client.cc

+++ b/content/shell/browser/shell_content_browser_client.cc

@@ -209,6 +209,16 @@ bool ShellContentBrowserClient::IsHandledURL(const GURL& url) {

void ShellContentBrowserClient::AppendExtraCommandLineSwitches(

base::CommandLine* command_line,

int child_process_id) {

+#if defined(OS_POSIX) && !defined(OS_MACOSX)

+#if defined(V8_USE_EXTERNAL_STARTUP_DATA)

+ std::string process_type =

+ command_line->GetSwitchValueASCII(switches::kProcessType);

+ if (process_type != switches::kZygoteProcess) {

+ command_line->AppendSwitch(::switches::kV8NativesPassedByFD);

+ command_line->AppendSwitch(::switches::kV8SnapshotPassedByFD);

+ }

+#endif // V8_USE_EXTERNAL_STARTUP_DATA

+#endif // OS_POSIX && !OS_MACOSX

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kRunLayoutTest))

command_line->AppendSwitch(switches::kRunLayoutTest);