Issue 107113005: Gin: Consolidate all the Converter<Wrappable> subclasses.

Issue 107113005: Gin: Consolidate all the Converter<Wrappable> subclasses. (Closed)

Created:
7 years ago by Aaron Boodman

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Gin: Consolidate all the Converter<Wrappable> subclasses. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239204

Patch Set 2 : Remove unneeded friend declaration #

Total comments: 1

Patch Set 3 : ok #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -77 lines)			Patch
M	gin/converter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gin/function_template.h	View	1 2	2 chunks	+1 line, -8 lines	0 comments	Download
M	gin/function_template.h.pump	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	gin/wrappable.h	View	1 2	3 chunks	+28 lines, -19 lines	1 comment	Download
M	gin/wrappable.cc	View		2 chunks	+3 lines, -25 lines	0 comments	Download
M	gin/wrappable_unittest.cc	View	1 2	3 chunks	+70 lines, -8 lines	0 comments	Download
M	mojo/apps/js/bindings/waiting_callback.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/107113005/diff/20001/gin/wrappable.h File gin/wrappable.h (left): https://codereview.chromium.org/107113005/diff/20001/gin/wrappable.h#oldcode83 gin/wrappable.h:83: || wrappable->GetWrapperInfo() != &T::kWrapperInfo) I think we're missing ...

7 years ago (2013-12-06 01:50:54 UTC) #2

Aaron Boodman

PTAL I also added some unittests to exercise this. In future CLs I will be ...

7 years ago (2013-12-06 03:30:25 UTC) #3

abarth-chromium

lgtm https://codereview.chromium.org/107113005/diff/40001/gin/wrappable.h File gin/wrappable.h (right): https://codereview.chromium.org/107113005/diff/40001/gin/wrappable.h#newcode98 gin/wrappable.h:98: return true; Perfect.

7 years ago (2013-12-06 03:35:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/107113005/40001

7 years ago (2013-12-06 09:35:48 UTC) #5

Message was sent while issue was closed.

Change committed as 239204

Expand Messages | Collapse Messages