Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: gin/function_template.h.pump

Issue 107113005: Gin: Consolidate all the Converter<Wrappable> subclasses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ok Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/function_template.h ('k') | gin/wrappable.h » ('j') | gin/wrappable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h.pump
diff --git a/gin/function_template.h.pump b/gin/function_template.h.pump
index d3ae98ba9c86d8ae20cdc35565573edd646a4f76..23941c08287209c8eb03c2d8d92d5e6c0a57d8b0 100644
--- a/gin/function_template.h.pump
+++ b/gin/function_template.h.pump
@@ -188,14 +188,6 @@ $for ARG [[ typename CallbackParamTraits<P$(ARG)>::LocalType a$(ARG);
void InitFunctionTemplates(PerIsolateData* isolate_data);
-// This has to be outside the internal namespace because template
-// specializations must be declared in the same namespace as the original
-// template.
-template<>
-struct Converter<internal::CallbackHolderBase*>
- : public WrappableConverter<internal::CallbackHolderBase> {};
-
-
// CreateFunctionTemplate creates a v8::FunctionTemplate that will create
// JavaScript functions that execute a provided C++ function or base::Callback.
// JavaScript arguments are automatically converted via gin::Converter, as is
« no previous file with comments | « gin/function_template.h ('k') | gin/wrappable.h » ('j') | gin/wrappable.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698