Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 107113002: Correctly define OVERRIDE / FINAL when building with g++ 4.7 and C++11 support (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Correctly define OVERRIDE / FINAL when building with g++ 4.7 and C++11 support g++ 4.7 and later support explicit virtual overrides when building with C++11 support enabled. Blink correctly detects that and defines OVERRIDE / FINAL properly. However, Chrome does not detect compiler support properly and makes OVERRIDE / FINAL no-ops. This causes the compiler to complain about OVERRIDE / FINAL being redefined. This CL updates base/compiler_specific.h to define OVERRIDE / FINAL properly when g++ 4.7 is used with C++11 support enabled. See this page for GCC support of C++11 features: http://gcc.gnu.org/projects/cxx0x.html BUG=233330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/compiler_specific.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
FYI, the exact same issue exists in webrtc and libjingle.
7 years ago (2013-12-05 20:38:11 UTC) #1
Nico
We don't build with C++11 mode when building with gcc though, right?
7 years ago (2013-12-05 20:40:26 UTC) #2
Nico
But sure, lgtm
7 years ago (2013-12-05 20:41:14 UTC) #3
Inactive
On 2013/12/05 20:40:26, Nico wrote: > We don't build with C++11 mode when building with ...
7 years ago (2013-12-05 20:54:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/107113002/1
7 years ago (2013-12-05 21:38:35 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=199492
7 years ago (2013-12-06 07:43:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/107113002/1
7 years ago (2013-12-06 14:08:33 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-06 14:16:27 UTC) #8
Message was sent while issue was closed.
Change committed as 239207

Powered by Google App Engine
This is Rietveld 408576698