base/compiler_specific.h - Issue 107113002: Correctly define OVERRIDE / FINAL when building with g++ 4.7 and C++11 support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/compiler_specific.h

Issue 107113002: Correctly define OVERRIDE / FINAL when building with g++ 4.7 and C++11 support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/compiler_specific.h

diff --git a/base/compiler_specific.h b/base/compiler_specific.h

index 409a613964cef2cf74c36ade8b040e5e63656757..dc4b23349873c8ae81e0312badd109bf2416f222 100644

--- a/base/compiler_specific.h

+++ b/base/compiler_specific.h

@@ -141,6 +141,10 @@

#define OVERRIDE override

#elif defined(__clang__)

#define OVERRIDE override

+#elif defined(COMPILER_GCC) && __cplusplus >= 201103 && \

+ (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700

+// GCC 4.7 supports explicit virtual overrides when C++11 support is enabled.

+#define OVERRIDE override

#else

#define OVERRIDE

#endif

@@ -155,6 +159,10 @@

#define FINAL sealed

#elif defined(__clang__)

#define FINAL final

+#elif defined(COMPILER_GCC) && __cplusplus >= 201103 && \

+ (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700

+// GCC 4.7 supports explicit virtual overrides when C++11 support is enabled.

+#define FINAL final

#else

#define FINAL

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »