Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 101403002: IDL compiler: Consolidate test IDL files (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: Consolidate test IDL files To facilitate reviewing, we want to minimize the number of test IDL files. This consolidates IDL files in a few ways, removing 7 of 30 files: * Consolidate most interface extended attributes into TestInterfacePython.idl * Some interface extended attributes overlap; the overlapping ones are put into TestInterfacePython2.idl * Interface extended attributes that also have content (that affect attributes and methods) are put in separate files, to keep these effects clear and separate -- this is currently just 2: TestInterfaceCheckSecurity.idl TestInterfaceDoNotCheckConstants.idl I'll use this format for future interface extended attributes, meaning: TestInterfacePython.idl if possible, others if necessary (as above). Also: * Delete TestSerializedScriptValueInterface.idl, as that's covered in TestObjectPython.idl (nothing interface-specific). * Merge TestConstants.idl into TestObjectPython.idl. It also renames for consistency: Test*Interface.idl => TestInterface*.idl (better collation). Once I'm finished with the rewrite, I'll go through the test cases again and see if we can consolidate or eliminate further. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163135

Patch Set 1 #

Patch Set 2 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -5381 lines) Patch
D Source/bindings/tests/idls/TestActiveDOMObjectInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/bindings/tests/idls/TestCheckSecurityInterface.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/bindings/tests/idls/TestConditionalInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/bindings/tests/idls/TestConstants.idl View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/bindings/tests/idls/TestCustomLegacyCallInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/bindings/tests/idls/TestCustomVisitDOMWrapperInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/bindings/tests/idls/TestCustomWrapInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/bindings/tests/idls/TestDependentLifetimeInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/bindings/tests/idls/TestDoNotCheckConstantsInterface.idl View 1 1 chunk +0 lines, -36 lines 0 comments Download
D Source/bindings/tests/idls/TestGenerateVisitDOMWrapperInterface.idl View 1 chunk +0 lines, -34 lines 0 comments Download
A + Source/bindings/tests/idls/TestInterfaceCheckSecurity.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/idls/TestInterfaceDoNotCheckConstants.idl View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/idls/TestInterfacePython.idl View 1 chunk +5 lines, -1 line 0 comments Download
A + Source/bindings/tests/idls/TestInterfacePython2.idl View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 2 chunks +25 lines, -0 lines 0 comments Download
D Source/bindings/tests/idls/TestSerializedScriptValueInterface.idl View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/bindings/tests/results/V8TestActiveDOMObject.h View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 1 chunk +0 lines, -420 lines 0 comments Download
D Source/bindings/tests/results/V8TestActiveDOMObjectInterface.h View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestActiveDOMObjectInterface.cpp View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestCheckSecurityInterface.h View 1 1 chunk +0 lines, -159 lines 0 comments Download
D Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp View 1 1 chunk +0 lines, -570 lines 0 comments Download
D Source/bindings/tests/results/V8TestConditionalInterface.h View 1 chunk +0 lines, -161 lines 0 comments Download
D Source/bindings/tests/results/V8TestConditionalInterface.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
D Source/bindings/tests/results/V8TestConstants.h View 1 chunk +0 lines, -159 lines 0 comments Download
D Source/bindings/tests/results/V8TestConstants.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
D Source/bindings/tests/results/V8TestCustomLegacyCallInterface.h View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
D Source/bindings/tests/results/V8TestCustomVisitDOMWrapperInterface.h View 1 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestCustomVisitDOMWrapperInterface.cpp View 1 1 chunk +0 lines, -155 lines 0 comments Download
D Source/bindings/tests/results/V8TestCustomWrapInterface.h View 1 chunk +0 lines, -154 lines 0 comments Download
D Source/bindings/tests/results/V8TestCustomWrapInterface.cpp View 1 chunk +0 lines, -155 lines 0 comments Download
D Source/bindings/tests/results/V8TestDependentLifetimeInterface.h View 1 chunk +0 lines, -159 lines 0 comments Download
D Source/bindings/tests/results/V8TestDependentLifetimeInterface.cpp View 1 chunk +0 lines, -155 lines 0 comments Download
D Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.h View 1 1 chunk +0 lines, -159 lines 0 comments Download
D Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp View 1 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestGenerateVisitDOMWrapperInterface.h View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/bindings/tests/results/V8TestGenerateVisitDOMWrapperInterface.cpp View 1 chunk +0 lines, -167 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 1 chunk +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 19 chunks +89 lines, -89 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h View 1 1 chunk +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 6 chunks +20 lines, -20 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython.h View 1 chunk +32 lines, -33 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython.cpp View 7 chunks +28 lines, -20 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython2.h View 1 chunk +30 lines, -33 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython2.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
D Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h View 1 chunk +0 lines, -161 lines 0 comments Download
D Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 1 chunk +0 lines, -334 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
CL consolidating 7/30 (23%) of test cases!
7 years ago (2013-12-03 08:47:11 UTC) #1
haraken
LGTM!
7 years ago (2013-12-03 09:09:46 UTC) #2
Nils Barth (inactive)
On 2013/12/03 09:09:46, haraken wrote: > LGTM! Thanks! I'm going to wait until the [CustomToV8] ...
7 years ago (2013-12-03 09:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/101403002/20001
7 years ago (2013-12-04 01:55:58 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-04 01:56:49 UTC) #5
Message was sent while issue was closed.
Change committed as 163135

Powered by Google App Engine
This is Rietveld 408576698