[Extension DocServer] Remove availability warning for enums

[Extension DocServer] Remove availability warning for enums

The availability warning for enums isn't really that helpful, since if an enum
is added somewhere, the availability warning will be on wherever it is used.

BUG=474980
Committed: https://crrev.com/057915a0e5410b4bb3b25a53deedcfd69b33a77b
Cr-Commit-Position: refs/heads/master@{#324287}

[Devlin, 2015-04-08 17:57:34]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-04-08 18:05:18]

lgtm

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/app.yaml (right):

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/app.yaml:2: version: 3-48-3
I don't trust that the dictionary you're modifying isn't cached, so this should
bump the middle version.

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/jsc_view.py (right):

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/jsc_view.py:457: # We don't show an
availability warning for enums.
If we *really* don't want to show availability warning for enums then this
should come before the check on line 455.

Also, comments on the line before an else-if are confusing. I'd put this whole
check at the top of this function.

Also, add TODO for fixing this properly and rendering the "available as a
symbolic constant from Chrome X" line.

[Devlin, 2015-04-08 19:44:02]

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/app.yaml (right):

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/app.yaml:2: version: 3-48-3
On 2015/04/08 18:05:17, kalman wrote:
> I don't trust that the dictionary you're modifying isn't cached, so this
should
> bump the middle version.

Done.

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/jsc_view.py (right):

https://codereview.chromium.org/1070873002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/jsc_view.py:457: # We don't show an
availability warning for enums.
On 2015/04/08 18:05:17, kalman wrote:
> If we *really* don't want to show availability warning for enums then this
> should come before the check on line 455.
> 
> Also, comments on the line before an else-if are confusing. I'd put this whole
> check at the top of this function.
> 
> Also, add TODO for fixing this properly and rendering the "available as a
> symbolic constant from Chrome X" line.

Done, done, and done.

[Devlin, 2015-04-08 19:44:07]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-04-08 19:44:08]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1070873002/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2015-04-08 19:45:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070873002/20001

[commit-bot: I haz the power, 2015-04-08 21:33:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-08 21:34:43]

Patchset 2 (id:??) landed as
https://crrev.com/057915a0e5410b4bb3b25a53deedcfd69b33a77b
Cr-Commit-Position: refs/heads/master@{#324287}