[Extension DocServer] Remove availability warning for enums

chrome/common/extensions/docs/server2/jsc_view.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from copy import copy
 import logging
 import posixpath
 
 from api_models import GetNodeCategories
 from api_schema_graph import APINodeCursor
@@ skipping 215 matching lines @@
     '''Returns a dictionary representation of a type from JSON Schema Compiler.
     '''
     with self._current_node.Descend(type_.simple_name):
       type_dict = {
         'name': type_.simple_name,
         'description': type_.description,
         'properties': self._GenerateProperties(type_.properties),
         'functions': self._GenerateFunctions(type_.functions),
         'events': self._GenerateEvents(type_.events),
         'id': _CreateId(type_, 'type'),
-        'availability': self._GetAvailabilityTemplate()
+        'availability': self._GetAvailabilityTemplate(
+            is_enum=type_.property_type == model.PropertyType.ENUM)
       }
       self._RenderTypeInformation(type_, type_dict)
       return type_dict
 
   def _GenerateFunctions(self, functions):
     '''Returns a list of dictionaries representing this Model's functions.
     '''
     with self._current_node.Descend('functions'):
       return [self._GenerateFunction(f) for f in functions.values()]
 
@@ skipping 190 matching lines @@
     '''Returns an object suitable for use in templates to display availability
     information.
     '''
     return {
       'partial': self._template_cache.GetFromFile(
           '%sintro_tables/%s_message.html' % (PRIVATE_TEMPLATES, status)).Get(),
       'scheduled': scheduled,
       'version': version
     }
 
-  def _GetAvailabilityTemplate(self):
+  def _GetAvailabilityTemplate(self, is_enum=False):
     '''Gets availability for the current node and returns an appropriate
     template object.
     '''
     # Displaying deprecated status takes precedence over when the API
     # became stable.
     availability_info = self._current_node.GetDeprecated()
     if availability_info is not None:
       status = 'deprecated'
+    # We don't show an availability warning for enums.

[not at google - send to devlin, 2015/04/08 18:05:17]

If we *really* don't want to show availability warning for enums then this
should come before the check on line 455.

Also, comments on the line before an else-if are confusing. I'd put this whole
check at the top of this function.

Also, add TODO for fixing this properly and rendering the "available as a
symbolic constant from Chrome X" line.

[Devlin, 2015/04/08 19:44:02]

Done, done, and done.

+    elif is_enum:
+      return None
     else:
       availability_info = self._current_node.GetAvailability()
       if availability_info is None:
         return None
       status = availability_info.channel_info.channel
     return self._CreateAvailabilityTemplate(
         status,
         availability_info.scheduled,
         availability_info.channel_info.version)
 
@@ skipping 156 matching lines @@
                   request):
   return _JSCViewBuilder(content_script_apis,
                          jsc_model,
                          availability_finder,
                          json_cache,
                          template_cache,
                          features_bundle,
                          event_byname_future,
                          platform,
                          samples).ToDict(request)