Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1940)

Unified Diff: content/renderer/skia_benchmarking_extension.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/v8_var_converter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/skia_benchmarking_extension.cc
diff --git a/content/renderer/skia_benchmarking_extension.cc b/content/renderer/skia_benchmarking_extension.cc
index d2f5d9d904843acd4a9fa09c44c455c87278579e..a00a8c10ae59f8ff02428ff577f73e11ca2a5b52 100644
--- a/content/renderer/skia_benchmarking_extension.cc
+++ b/content/renderer/skia_benchmarking_extension.cc
@@ -222,9 +222,9 @@ class SkiaBenchmarkingWrapper : public v8::Extension {
v8::Handle<v8::Object> result = v8::Object::New(isolate);
result->Set(v8::String::NewFromUtf8(isolate, "width"),
- v8::Number::New(snapped_clip.width()));
+ v8::Number::New(isolate, snapped_clip.width()));
result->Set(v8::String::NewFromUtf8(isolate, "height"),
- v8::Number::New(snapped_clip.height()));
+ v8::Number::New(isolate, snapped_clip.height()));
result->Set(v8::String::NewFromUtf8(isolate, "data"), buffer.toV8Value());
args.GetReturnValue().Set(result);
@@ -300,11 +300,12 @@ class SkiaBenchmarkingWrapper : public v8::Extension {
v8::Local<v8::Array> op_times =
v8::Array::New(isolate, benchmarking_canvas.CommandCount());
for (size_t i = 0; i < benchmarking_canvas.CommandCount(); ++i)
- op_times->Set(i, v8::Number::New(benchmarking_canvas.GetTime(i)));
+ op_times->Set(i, v8::Number::New(isolate,
+ benchmarking_canvas.GetTime(i)));
v8::Handle<v8::Object> result = v8::Object::New(isolate);
result->Set(v8::String::NewFromUtf8(isolate, "total_time"),
- v8::Number::New(total_time.InMillisecondsF()));
+ v8::Number::New(isolate, total_time.InMillisecondsF()));
result->Set(v8::String::NewFromUtf8(isolate, "cmd_times"), op_times);
args.GetReturnValue().Set(result);
@@ -321,9 +322,9 @@ class SkiaBenchmarkingWrapper : public v8::Extension {
v8::Handle<v8::Object> result = v8::Object::New(isolate);
result->Set(v8::String::NewFromUtf8(isolate, "width"),
- v8::Number::New(picture->LayerRect().width()));
+ v8::Number::New(isolate, picture->LayerRect().width()));
result->Set(v8::String::NewFromUtf8(isolate, "height"),
- v8::Number::New(picture->LayerRect().height()));
+ v8::Number::New(isolate, picture->LayerRect().height()));
args.GetReturnValue().Set(result);
}
« no previous file with comments | « content/renderer/pepper/v8_var_converter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698