content/renderer/pepper/v8_var_converter.cc - Issue 107083006: More v8-API-related cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/v8_var_converter.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/v8_var_converter.cc

diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc

index e7e66d940a1027939e5e0fa5e63884ced07cab82..f2d7271a036a61ef0edaedf82fcd25b63ff426da 100644

--- a/content/renderer/pepper/v8_var_converter.cc

+++ b/content/renderer/pepper/v8_var_converter.cc

@@ -112,10 +112,10 @@ bool GetOrCreateV8Value(v8::Isolate* isolate,

: v8::False(isolate);

break;

case PP_VARTYPE_INT32:

- *result = v8::Integer::New(var.value.as_int);

+ *result = v8::Integer::New(isolate, var.value.as_int);

break;

case PP_VARTYPE_DOUBLE:

- *result = v8::Number::New(var.value.as_double);

+ *result = v8::Number::New(isolate, var.value.as_double);

break;

case PP_VARTYPE_STRING: {

StringVar* string = StringVar::FromPPVar(var);