Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/renderer/extensions/set_icon_natives.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/set_icon_natives.cc
diff --git a/chrome/renderer/extensions/set_icon_natives.cc b/chrome/renderer/extensions/set_icon_natives.cc
index 279e9d08d1925b99224df3f9b0c606be88bf2dd5..e80c4a426cb88812e263d028d7ed887851e6f564 100644
--- a/chrome/renderer/extensions/set_icon_natives.cc
+++ b/chrome/renderer/extensions/set_icon_natives.cc
@@ -80,10 +80,14 @@ bool SetIconNatives::ConvertImageDataToBitmapValue(
for (int t = 0; t < width*height; t++) {
// |data| is RGBA, pixels is ARGB.
pixels[t] = SkPreMultiplyColor(
- ((data->Get(v8::Integer::New(4*t + 3))->Int32Value() & 0xFF) << 24) |
- ((data->Get(v8::Integer::New(4*t + 0))->Int32Value() & 0xFF) << 16) |
- ((data->Get(v8::Integer::New(4*t + 1))->Int32Value() & 0xFF) << 8) |
- ((data->Get(v8::Integer::New(4*t + 2))->Int32Value() & 0xFF) << 0));
+ ((data->Get(v8::Integer::New(isolate, 4*t + 3))->Int32Value() & 0xFF)
+ << 24) |
+ ((data->Get(v8::Integer::New(isolate, 4*t + 0))->Int32Value() & 0xFF)
+ << 16) |
+ ((data->Get(v8::Integer::New(isolate, 4*t + 1))->Int32Value() & 0xFF)
+ << 8) |
+ ((data->Get(v8::Integer::New(isolate, 4*t + 2))->Int32Value() & 0xFF)
+ << 0));
}
// Construct the Value object.
« no previous file with comments | « chrome/renderer/extensions/runtime_custom_bindings.cc ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698