chrome/renderer/extensions/runtime_custom_bindings.cc - Issue 107083006: More v8-API-related cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/runtime_custom_bindings.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/runtime_custom_bindings.cc

diff --git a/chrome/renderer/extensions/runtime_custom_bindings.cc b/chrome/renderer/extensions/runtime_custom_bindings.cc

index e2030d14a1ab12d30bda0373e2d7799dd68422f8..fd92526eb77f99d76d92c3425090a2366a41d10d 100644

--- a/chrome/renderer/extensions/runtime_custom_bindings.cc

+++ b/chrome/renderer/extensions/runtime_custom_bindings.cc

@@ -167,7 +167,7 @@ void RuntimeCustomBindings::GetExtensionViews(

if (!context.IsEmpty()) {

v8::Local<v8::Value> window = context->Global();

DCHECK(!window.IsEmpty());

- v8_views->Set(v8::Integer::New(v8_index++), window);

+ v8_views->Set(v8::Integer::New(args.GetIsolate(), v8_index++), window);

}