Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4104)

Unified Diff: chrome/renderer/extensions/page_actions_custom_bindings.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/page_actions_custom_bindings.cc
diff --git a/chrome/renderer/extensions/page_actions_custom_bindings.cc b/chrome/renderer/extensions/page_actions_custom_bindings.cc
index c413d5ec68e2080ade21f839b3c0de7ea71f7705..54b7e97aa69860bb27ad2586dbfa3f86701717c8 100644
--- a/chrome/renderer/extensions/page_actions_custom_bindings.cc
+++ b/chrome/renderer/extensions/page_actions_custom_bindings.cc
@@ -31,11 +31,12 @@ void PageActionsCustomBindings::GetCurrentPageActions(
dispatcher_->extensions()->GetByID(extension_id);
CHECK(extension);
- v8::Local<v8::Array> page_action_vector = v8::Array::New(args.GetIsolate());
+ v8::Isolate* isolate = args.GetIsolate();
+ v8::Local<v8::Array> page_action_vector = v8::Array::New(isolate);
if (ActionInfo::GetPageActionInfo(extension)) {
std::string id = ActionInfo::GetPageActionInfo(extension)->id;
- page_action_vector->Set(v8::Integer::New(0),
- v8::String::NewFromUtf8(args.GetIsolate(),
+ page_action_vector->Set(v8::Integer::New(isolate, 0),
+ v8::String::NewFromUtf8(isolate,
id.c_str(),
v8::String::kNormalString,
id.size()));
« no previous file with comments | « chrome/renderer/extensions/messaging_bindings.cc ('k') | chrome/renderer/extensions/pepper_request_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698