Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: chrome/renderer/extensions/messaging_bindings.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/messaging_bindings.cc
diff --git a/chrome/renderer/extensions/messaging_bindings.cc b/chrome/renderer/extensions/messaging_bindings.cc
index 48f964d957bef60309ffba6e0de3dcb3e4bdd264..2dc79057f987e71717f2ad12d54c7ac45dbf90bf 100644
--- a/chrome/renderer/extensions/messaging_bindings.cc
+++ b/chrome/renderer/extensions/messaging_bindings.cc
@@ -289,7 +289,7 @@ void MessagingBindings::DispatchOnConnect(
}
v8::Handle<v8::Value> arguments[] = {
- v8::Integer::New(target_port_id),
+ v8::Integer::New(isolate, target_port_id),
v8::String::NewFromUtf8(isolate,
channel_name.c_str(),
v8::String::kNormalString,
@@ -359,7 +359,8 @@ void MessagingBindings::DeliverMessage(
// Check to see whether the context has this port before bothering to create
// the message.
- v8::Handle<v8::Value> port_id_handle = v8::Integer::New(target_port_id);
+ v8::Handle<v8::Value> port_id_handle =
+ v8::Integer::New(isolate, target_port_id);
v8::Handle<v8::Value> has_port = (*it)->module_system()->CallModuleMethod(
"messaging",
"hasPort",
@@ -403,7 +404,7 @@ void MessagingBindings::DispatchOnDisconnect(
continue;
std::vector<v8::Handle<v8::Value> > arguments;
- arguments.push_back(v8::Integer::New(port_id));
+ arguments.push_back(v8::Integer::New(isolate, port_id));
if (!error_message.empty()) {
arguments.push_back(
v8::String::NewFromUtf8(isolate, error_message.c_str()));
« no previous file with comments | « chrome/renderer/extensions/i18n_custom_bindings.cc ('k') | chrome/renderer/extensions/page_actions_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698