Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1070703002: Explicitly use SkPaint(s) in SVGInlineTextBoxPainter (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, krit, Justin Novosad, danakj, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, gyuyoung2, pdr+svgwatchlist_chromium.org, zoltan1, jbroman, Dominik Röttsches, pdr+graphicswatchlist_chromium.org, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Explicitly use SkPaint(s) in SVGInlineTextBoxPainter Move paintForLayoutObject from SVGShapePainter.cpp to SVGPaintContext, and use it when setting up paints for decorations and text in SVGInlineTextBoxPainter. This eliminates the last users of SVGLayoutSupport functions updateGraphicsContext() and applyStrokeStyleToContext(), as well as SVGPaintServer::apply(). BUG=424655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193360

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -142 lines) Patch
M Source/core/layout/svg/LayoutSVGResourcePaintServer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp View 2 chunks +1 line, -26 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.h View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +0 lines, -48 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 4 chunks +25 lines, -15 lines 0 comments Download
M Source/core/paint/SVGPaintContext.h View 2 chunks +5 lines, -0 lines 2 comments Download
M Source/core/paint/SVGPaintContext.cpp View 1 chunk +37 lines, -0 lines 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 3 chunks +2 lines, -39 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 8 months ago (2015-04-08 14:15:57 UTC) #2
f(malita)
lgtm https://codereview.chromium.org/1070703002/diff/1/Source/core/paint/SVGPaintContext.h File Source/core/paint/SVGPaintContext.h (right): https://codereview.chromium.org/1070703002/diff/1/Source/core/paint/SVGPaintContext.h#newcode71 Source/core/paint/SVGPaintContext.h:71: static bool paintForLayoutObject(const PaintInfo&, const ComputedStyle&, LayoutObject&, LayoutSVGResourceMode, ...
5 years, 8 months ago (2015-04-08 14:49:14 UTC) #3
fs
https://codereview.chromium.org/1070703002/diff/1/Source/core/paint/SVGPaintContext.h File Source/core/paint/SVGPaintContext.h (right): https://codereview.chromium.org/1070703002/diff/1/Source/core/paint/SVGPaintContext.h#newcode71 Source/core/paint/SVGPaintContext.h:71: static bool paintForLayoutObject(const PaintInfo&, const ComputedStyle&, LayoutObject&, LayoutSVGResourceMode, SkPaint&, ...
5 years, 8 months ago (2015-04-08 15:03:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070703002/1
5 years, 8 months ago (2015-04-08 15:04:04 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:09:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193360

Powered by Google App Engine
This is Rietveld 408576698