Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1070643002: Fix strings in dialogs for chrome.fileSystem.requestFileSystem. (Closed)

Created:
5 years, 8 months ago by mtomasz
Modified:
5 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix strings in dialogs for chrome.fileSystem.requestFileSystem. TEST=Tested manually. BUG=440674 Committed: https://crrev.com/b291bd1947dac4f9c980110f2ef8f7cc1e08c4ce Cr-Commit-Position: refs/heads/master@{#324204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc View 2 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hirono: PTAL. Thanks!
5 years, 8 months ago (2015-04-08 09:07:08 UTC) #2
hirono
lgtm!
5 years, 8 months ago (2015-04-08 09:20:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070643002/1
5 years, 8 months ago (2015-04-08 09:26:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 09:58:09 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 09:59:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b291bd1947dac4f9c980110f2ef8f7cc1e08c4ce
Cr-Commit-Position: refs/heads/master@{#324204}

Powered by Google App Engine
This is Rietveld 408576698