[Android WebView] Upstream WebViewShell to chromium.

[Android WebView] Upstream WebViewShell to chromium.

WebViewShell used to live in the android repository. This patch
upstreams it to the chromium repository and adds a new target
android_webview_shell_apk. That way both the AndroidWebViewShell.apk
and SystemWebViewGoogle.apk can be built at the same time using one
checkout.

In particular this patch does the following:
- copy the relevant files residing in the android repository under
  frameworks/webview/chromium/tools/WebViewShell/
- add necessary gyp files
- rename the package name to org.chromium.webview_shell
- some import clean ups and formatting
- replace license headers

BUG=475084
Committed: https://crrev.com/86221dd2181ee4e29a0c30a8674ae263007e165f
Cr-Commit-Position: refs/heads/master@{#325854}

[timvolodine, 2015-04-08 18:40:17]

timvolodine@chromium.org changed reviewers:
+ torne@chromium.org

[boliu, 2015-04-08 18:44:18]

I'd suggest merging this into WebViewTelemetryShell instead of creating yet
another test shell that no one has any idea what it's being used for. It's not
like we are in desperate need of this right now?

[timvolodine, 2015-04-10 18:14:24]

On 2015/04/08 18:44:18, boliu wrote:
> I'd suggest merging this into WebViewTelemetryShell instead of creating yet
> another test shell that no one has any idea what it's being used for. It's not
> like we are in desperate need of this right now?

I think I'd prefer this the other way around. The TelemetryActivity and
JankActivity of WebViewTelemetryShell are identical to those in this patch. We
could simply replace AndroidWebViewTelemetryShell target with
AndroidWebViewShell. I think this can be best done in a separate patch so that
it can be rolled back if things go wrong. That way we'll also have a more
generic name WebViewShell similar to ContentShell for chrome. Does that sound
reasonable?

[boliu, 2015-04-10 18:42:18]

On 2015/04/10 18:14:24, timvolodine wrote:
> On 2015/04/08 18:44:18, boliu wrote:
> > I'd suggest merging this into WebViewTelemetryShell instead of creating yet
> > another test shell that no one has any idea what it's being used for. It's
not
> > like we are in desperate need of this right now?
> 
> I think I'd prefer this the other way around. The TelemetryActivity and
> JankActivity of WebViewTelemetryShell are identical to those in this patch. We
> could simply replace AndroidWebViewTelemetryShell target with
> AndroidWebViewShell. I think this can be best done in a separate patch so that
> it can be rolled back if things go wrong. That way we'll also have a more
> generic name WebViewShell similar to ContentShell for chrome. Does that sound
> reasonable?

Renaming things is hard, since you have to make sure all the bots and scripts
with that name are updated. And requires some churn (which is why
"android_webview_apk" still has that terribly confusing name..)

But if it's easy for WebViewTelemetryShell, then sure.

[timvolodine, 2015-04-13 12:07:06]

On 2015/04/10 18:42:18, boliu wrote:
> On 2015/04/10 18:14:24, timvolodine wrote:
> > On 2015/04/08 18:44:18, boliu wrote:
> > > I'd suggest merging this into WebViewTelemetryShell instead of creating
yet
> > > another test shell that no one has any idea what it's being used for. It's
> not
> > > like we are in desperate need of this right now?
> > 
> > I think I'd prefer this the other way around. The TelemetryActivity and
> > JankActivity of WebViewTelemetryShell are identical to those in this patch.
We
> > could simply replace AndroidWebViewTelemetryShell target with
> > AndroidWebViewShell. I think this can be best done in a separate patch so
that
> > it can be rolled back if things go wrong. That way we'll also have a more
> > generic name WebViewShell similar to ContentShell for chrome. Does that
sound
> > reasonable?
> 
> Renaming things is hard, since you have to make sure all the bots and scripts
> with that name are updated. And requires some churn (which is why
> "android_webview_apk" still has that terribly confusing name..)
> 
> But if it's easy for WebViewTelemetryShell, then sure.

yes, in this case for WebViewTelemetryShell renaming seems relatively easy as it
seems to be used by only one perf bot. so I think merging would actually be
harder and more confusing..
torne@: any comments on this?

[Torne, 2015-04-13 12:41:59]

I think we should go ahead and land this, then update the telemetry bot script
to use this package instead of the older one, then just delete the old one. It
seems fine for them to be in a single app as it lets the different test
activities share code/resources, and a three-sided patch like that is the
easiest way to rename something :)

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
File android_webview/tools/WebViewShell/AndroidManifest.xml (right):

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/AndroidManifest.xml:12: <uses-sdk
android:minSdkVersion="17"
Does this need to be 17 for some particular reason? If not we should set it to
19 instead (kitkat).

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/AndroidManifest.xml:18: <application
nit: inconsistent indentation in this file

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
File android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml
(right):

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml:1: <?xml
version="1.0" encoding="utf-8"?>
Maybe name this layout activity_webview? It's not just used by telemetry, and
it's just a webview. :)

[timvolodine, 2015-04-13 22:04:06]

thanks for the comments! PTAL.

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
File android_webview/tools/WebViewShell/AndroidManifest.xml (right):

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/AndroidManifest.xml:12: <uses-sdk
android:minSdkVersion="17"
On 2015/04/13 12:41:59, Torne wrote:
> Does this need to be 17 for some particular reason? If not we should set it to
> 19 instead (kitkat).

Done.

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/AndroidManifest.xml:18: <application
On 2015/04/13 12:41:59, Torne wrote:
> nit: inconsistent indentation in this file

Done.

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
File android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml
(right):

https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml:1: <?xml
version="1.0" encoding="utf-8"?>
On 2015/04/13 12:41:59, Torne wrote:
> Maybe name this layout activity_webview? It's not just used by telemetry, and
> it's just a webview. :)

Done.

[timvolodine, 2015-04-15 17:18:16]

On 2015/04/13 22:04:06, timvolodine wrote:
> thanks for the comments! PTAL.
> 
>
https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
> File android_webview/tools/WebViewShell/AndroidManifest.xml (right):
> 
>
https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
> android_webview/tools/WebViewShell/AndroidManifest.xml:12: <uses-sdk
> android:minSdkVersion="17"
> On 2015/04/13 12:41:59, Torne wrote:
> > Does this need to be 17 for some particular reason? If not we should set it
to
> > 19 instead (kitkat).
> 
> Done.
> 
>
https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
> android_webview/tools/WebViewShell/AndroidManifest.xml:18: <application
> On 2015/04/13 12:41:59, Torne wrote:
> > nit: inconsistent indentation in this file
> 
> Done.
> 
>
https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
> File android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml
> (right):
> 
>
https://codereview.chromium.org/1070563005/diff/20001/android_webview/tools/W...
> android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml:1: <?xml
> version="1.0" encoding="utf-8"?>
> On 2015/04/13 12:41:59, Torne wrote:
> > Maybe name this layout activity_webview? It's not just used by telemetry,
and
> > it's just a webview. :)
> 
> Done.

torne@: ping ;) does it look ok to you now?

[Torne, 2015-04-16 14:10:47]

lgtm

[timvolodine, 2015-04-16 14:14:19]

timvolodine@chromium.org changed reviewers:
+ thakis@chromium.org

[timvolodine, 2015-04-16 14:14:20]

+thakis@ for build/all.gyp

[Nico, 2015-04-16 16:53:24]

build/all.gyp lgtm. Exciting!

Do you want to add this to some gn file too?

[Nico, 2015-04-16 16:54:04]

https://codereview.chromium.org/1070563005/diff/60001/android_webview/tools/W...
File android_webview/tools/WebViewShell/run_startup_time_test.sh (right):

https://codereview.chromium.org/1070563005/diff/60001/android_webview/tools/W...
android_webview/tools/WebViewShell/run_startup_time_test.sh:33: sleep 0.5
this script tho :-/

[Nico, 2015-04-16 16:54:57]

(and if you feel like it, maybe say "2015" in all the copyright notes)

[Torne, 2015-04-16 16:57:26]

On 2015/04/16 16:54:04, Nico wrote:
>
https://codereview.chromium.org/1070563005/diff/60001/android_webview/tools/W...
> File android_webview/tools/WebViewShell/run_startup_time_test.sh (right):
> 
>
https://codereview.chromium.org/1070563005/diff/60001/android_webview/tools/W...
> android_webview/tools/WebViewShell/run_startup_time_test.sh:33: sleep 0.5
> this script tho :-/

This script is a preexisting thing that we're moving upstream, we know it's
gross. We intend to have a properly perf-integrated way of measuring startup
time, but it's not implemented yet, so we're keeping this around until we have
:)

We don't currently have gn files for anything in android_webview at all, sorry.
We were ignoring it until we'd actually gotten rid of the AOSP build. We should
work with the other android chromium people who are doing the GN conversion to
get webview covered as well, but I don't think it makes sense to start here :)

[timvolodine, 2015-04-20 15:15:32]

thanks, fixed the copyright year to 2015.

[timvolodine, 2015-04-20 15:21:37]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2015-04-20 15:21:38]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1070563005/#ps80001
(title: "fix copyright year")

[commit-bot: I haz the power, 2015-04-20 15:21:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070563005/80001

[commit-bot: I haz the power, 2015-04-20 16:12:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-20 16:13:11]

Patchset 5 (id:??) landed as
https://crrev.com/86221dd2181ee4e29a0c30a8674ae263007e165f
Cr-Commit-Position: refs/heads/master@{#325854}