android_webview/tools/WebViewShell/AndroidManifest.xml - Issue 1070563005: [Android WebView] Upstream WebViewShell to chromium.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/tools/WebViewShell/AndroidManifest.xml

Issue 1070563005: [Android WebView] Upstream WebViewShell to chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix xml license headers + no-find-copies Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « android_webview/android_webview_shell.gyp ('k') | android_webview/tools/WebViewShell/res/drawable/ic_launcher.png » ('j') | android_webview/tools/WebViewShell/res/layout/activity_telemetry.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 * Copyright 2013 The Chromium Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be

	4 * found in the LICENSE file.

	5 -->

	6

	7 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

	8 package="org.chromium.webview_shell"

	9 android:versionCode="1"

	10 android:versionName="1.0" >

	11

	12 <uses-sdk android:minSdkVersion="17"
	Torne 2015/04/13 12:41:59 Does this need to be 17 for some particular reason Does this need to be 17 for some particular reason? If not we should set it to 19 instead (kitkat). timvolodine 2015/04/13 22:04:06 Done. Show quoted text On 2015/04/13 12:41:59, Torne wrote: > Does this need to be 17 for some particular reason? If not we should set it to > 19 instead (kitkat). Done.
	13 android:targetSdkVersion="22" />

	14

	15 <uses-permission android:name="android.permission.INTERNET" />

	16 <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>

	17

	18 <application
	Torne 2015/04/13 12:41:59 nit: inconsistent indentation in this file nit: inconsistent indentation in this file timvolodine 2015/04/13 22:04:05 Done. Show quoted text On 2015/04/13 12:41:59, Torne wrote: > nit: inconsistent indentation in this file Done.
	19 android:icon="@drawable/ic_launcher"

	20 android:label="@string/app_name"

	21 android:theme="@android:style/Theme.Light" >

	22 <activity

	23 android:name=".TelemetryActivity"

	24 android:label="@string/title_activity_telemetry"

	25 android:exported="true">

	26 </activity>

	27 <activity

	28 android:name=".JankActivity"

	29 android:label="@string/title_activity_jank"

	30 android:noHistory="true"

	31 android:exported="true">

	32 </activity>

	33 <activity

	34 android:name=".StartupTimeActivity"

	35 android:label="@string/title_activity_startup_time"

	36 android:noHistory="true"

	37 android:exported="true">

	38 </activity>

	39 <activity

	40 android:name=".WebViewBrowserActivity"

	41 android:label="@string/title_activity_browser"

	42 android:exported="true">

	43 <intent-filter>

	44 <action android:name="android.intent.action.VIEW" />

	45 <category android:name="android.intent.category.DEFAULT" />

	46 <category android:name="android.intent.category.BROWSABLE" />

	47 <data android:scheme="http" />

	48 <data android:scheme="https" />

	49 </intent-filter>

	50 </activity>

	51 </application>

	52 </manifest>

OLD	NEW