components/signin/core/browser/account_reconcilor.h - Issue 1070563004: GCMS has automatic checks for CheckExternalConnections. It will be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_reconcilor.h

Issue 1070563004: GCMS has automatic checks for CheckExternalConnections. It will be (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: AccountReconcilor tests need a fake list_accounts response, not a fake check_cc_results response. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/signin/core/browser/account_reconcilor.h

diff --git a/components/signin/core/browser/account_reconcilor.h b/components/signin/core/browser/account_reconcilor.h

index 06066b06fad3380c324e72c264fbd3e582443996..1350aa3a91866be9e7f73897d3f570d488c4021a 100644

--- a/components/signin/core/browser/account_reconcilor.h

+++ b/components/signin/core/browser/account_reconcilor.h

@@ -161,7 +161,6 @@ class AccountReconcilor : public KeyedService,

void OnAddAccountToCookieCompleted(

const std::string& account_id,

const GoogleServiceAuthError& error) override;

- void GetCheckConnectionInfoCompleted(bool succeeded) override;

// Overriden from OAuth2TokenService::Observer.

void OnEndBatchChanges() override;

« no previous file with comments | « chrome/browser/signin/account_reconcilor_unittest.cc ('k') | components/signin/core/browser/account_reconcilor.cc » ('j') | no next file with comments »