Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: components/signin/core/browser/account_reconcilor.cc

Issue 1070563004: GCMS has automatic checks for CheckExternalConnections. It will be (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: AccountReconcilor tests need a fake list_accounts response, not a fake check_cc_results response. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/account_reconcilor.cc
diff --git a/components/signin/core/browser/account_reconcilor.cc b/components/signin/core/browser/account_reconcilor.cc
index e4e2e3d4dd38cb4baebe23b73164a511ba7356bc..efe594db0e528b9791250382726747f2b511f1e3 100644
--- a/components/signin/core/browser/account_reconcilor.cc
+++ b/components/signin/core/browser/account_reconcilor.cc
@@ -304,10 +304,9 @@ void AccountReconcilor::StartReconcile() {
add_to_cookie_.clear();
ValidateAccountsFromTokenService();
- // TODO(mlerman): Call this only from within the GaiaCookieManagerService,
- // once /ListAccounts is now called from that class instead of the
- // reconcilor's GaiaAuthFetcher (which will be removed).
- cookie_manager_service_->StartFetchingExternalCcResult();
+ GetAccountsFromCookie(base::Bind(
+ &AccountReconcilor::ContinueReconcileActionAfterGetGaiaAccounts,
+ base::Unretained(this)));
}
void AccountReconcilor::GetAccountsFromCookie(
@@ -539,11 +538,3 @@ void AccountReconcilor::OnAddAccountToCookieCompleted(
ScheduleStartReconcileIfChromeAccountsChanged();
}
}
-
-void AccountReconcilor::GetCheckConnectionInfoCompleted(bool succeeded) {
- if (is_reconcile_started_) {
- GetAccountsFromCookie(base::Bind(
- &AccountReconcilor::ContinueReconcileActionAfterGetGaiaAccounts,
- base::Unretained(this)));
- }
-}
« no previous file with comments | « components/signin/core/browser/account_reconcilor.h ('k') | components/signin/core/browser/gaia_cookie_manager_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698