Chromium Code Reviews

Issue 1070313002: Add firefox support. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Patch Set 3 : Don't double-compile test suites #

Unified diffs Side-by-side diffs Stats (+200 lines, -111 lines)
M CHANGELOG.md View 1 chunk +2 lines, -0 lines 0 comments
M lib/src/backend/test_platform.dart View 1 chunk +8 lines, -3 lines 0 comments
A lib/src/runner/browser/browser.dart View 1 chunk +29 lines, -0 lines 0 comments
M lib/src/runner/browser/chrome.dart View 4 chunks +2 lines, -9 lines 0 comments
A + lib/src/runner/browser/firefox.dart View 8 chunks +25 lines, -31 lines 0 comments
M lib/src/runner/browser/server.dart View 7 chunks +87 lines, -49 lines 0 comments
M lib/src/runner/loader.dart View 2 chunks +4 lines, -3 lines 0 comments
A + test/runner/browser/firefox_test.dart View 6 chunks +13 lines, -13 lines 0 comments
M test/runner/browser/runner_test.dart View 3 chunks +29 lines, -2 lines 0 comments
M test/runner/runner_test.dart View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 9 (1 generated)
nweiz
5 years, 8 months ago (2015-04-09 21:31:16 UTC) #2
kevmoo
https://codereview.chromium.org/1070313002/diff/1/lib/src/backend/test_platform.dart File lib/src/backend/test_platform.dart (right): https://codereview.chromium.org/1070313002/diff/1/lib/src/backend/test_platform.dart#newcode21 lib/src/backend/test_platform.dart:21: static const firefox = const TestPlatform._("Firefox", "firefox", Per the ...
5 years, 8 months ago (2015-04-09 22:10:01 UTC) #3
nweiz
code review
5 years, 8 months ago (2015-04-09 22:24:50 UTC) #4
nweiz
https://codereview.chromium.org/1070313002/diff/1/lib/src/backend/test_platform.dart File lib/src/backend/test_platform.dart (right): https://codereview.chromium.org/1070313002/diff/1/lib/src/backend/test_platform.dart#newcode21 lib/src/backend/test_platform.dart:21: static const firefox = const TestPlatform._("Firefox", "firefox", On 2015/04/09 ...
5 years, 8 months ago (2015-04-09 22:24:55 UTC) #5
kevmoo
LGTM!!!
5 years, 8 months ago (2015-04-09 22:33:12 UTC) #6
nweiz
On 2015/04/09 22:33:12, kevmoo wrote: > LGTM!!! PTAL I realized that this was double-compiling if ...
5 years, 8 months ago (2015-04-10 00:38:13 UTC) #7
kevmoo
great idea! LGTM
5 years, 8 months ago (2015-04-10 00:41:37 UTC) #8
nweiz
5 years, 8 months ago (2015-04-10 18:17:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
45c6248814f7c7765bca7efa72a8837b727e681f (presubmit successful).

Powered by Google App Engine