Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: lib/src/runner/loader.dart

Issue 1070313002: Add firefox support. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Don't double-compile test suites Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/server.dart ('k') | test/runner/browser/firefox_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index 6eea6df389748c27603de30bd4367f2d8a740395..b148e73c1c3a40342e44668da00332f8cc921aa8 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -118,7 +118,7 @@ class Loader {
'When using "pub serve", all test files must be in test/.');
}
- if (platform == TestPlatform.chrome) return _loadBrowserFile(path);
+ if (platform.isBrowser) return _loadBrowserFile(path, platform);
assert(platform == TestPlatform.vm);
return _loadVmFile(path);
}).then((suite) {
@@ -129,8 +129,9 @@ class Loader {
}
/// Load the test suite at [path] in a browser.
- Future<Suite> _loadBrowserFile(String path) =>
- _browserServer.then((browserServer) => browserServer.loadSuite(path));
+ Future<Suite> _loadBrowserFile(String path, TestPlatform platform) =>
+ _browserServer.then((browserServer) =>
+ browserServer.loadSuite(path, platform));
/// Load the test suite at [path] in VM isolate.
Future<Suite> _loadVmFile(String path) {
« no previous file with comments | « lib/src/runner/browser/server.dart ('k') | test/runner/browser/firefox_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698