Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1070273004: DevTools: improve sort by column usability in heap profiler (Closed)

Created:
5 years, 8 months ago by yurys
Modified:
5 years, 8 months ago
Reviewers:
alph
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org, gauravvijay_google.com
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: improve sort by column usability in heap profiler When sorting by "Constructor" or "Objects count" column in summary view objects of the same class are now sorted by name. The same is now true for the Comparison view: if top level nodes are sorted by constructor name or added/removed/delta count the actual objects on second level will be sorted by name. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194307

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
yurys
5 years, 8 months ago (2015-04-23 14:53:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070273004/20001
5 years, 8 months ago (2015-04-23 14:57:23 UTC) #4
alph
lgtm
5 years, 8 months ago (2015-04-23 14:57:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070273004/20001
5 years, 8 months ago (2015-04-23 15:38:39 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 16:11:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194307

Powered by Google App Engine
This is Rietveld 408576698