Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 1070273004: DevTools: improve sort by column usability in heap profiler (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js b/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
index 70f4d6906427a905a3880952d5dea42db91e9a40..7659a10b0ed41fa5ff0fa66b0a0e7adbc62d7e21 100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
@@ -1143,9 +1143,9 @@ WebInspector.HeapSnapshotConstructorNode.prototype = {
var sortAscending = this._dataGrid.isSortOrderAscending();
var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
var sortFields = {
- object: ["id", sortAscending, "retainedSize", false],
+ object: ["name", sortAscending, "id", true],
distance: ["distance", sortAscending, "retainedSize", false],
- count: ["id", true, "retainedSize", false],
+ count: ["name", true, "id", true],
shallowSize: ["selfSize", sortAscending, "id", true],
retainedSize: ["retainedSize", sortAscending, "id", true]
}[sortColumnIdentifier];
@@ -1392,10 +1392,10 @@ WebInspector.HeapSnapshotDiffNode.prototype = {
var sortAscending = this._dataGrid.isSortOrderAscending();
var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
var sortFields = {
- object: ["id", sortAscending, "selfSize", false],
- addedCount: ["selfSize", sortAscending, "id", true],
- removedCount: ["selfSize", sortAscending, "id", true],
- countDelta: ["selfSize", sortAscending, "id", true],
+ object: ["name", sortAscending, "id", true],
+ addedCount: ["name", true, "id", true],
+ removedCount: ["name", true, "id", true],
+ countDelta: ["name", true, "id", true],
addedSize: ["selfSize", sortAscending, "id", true],
removedSize: ["selfSize", sortAscending, "id", true],
sizeDelta: ["selfSize", sortAscending, "id", true]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698