Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1070263002: remove CSS quotes property (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
ojan, Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

remove CSS quotes property The support was gone, this is just dead code. R=ianh@google.com, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b1a68e484d9ab76b85363eddb8e797d232e95964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -197 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 2 chunks +0 lines, -24 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderConverter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/rendering/style/QuotesData.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/core/rendering/style/QuotesData.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.cpp View 4 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
lgtm
5 years, 8 months ago (2015-04-09 20:42:26 UTC) #1
eseidel
didn't mean to lgtm my own patch. :p
5 years, 8 months ago (2015-04-09 20:42:39 UTC) #2
Hixie
lgtm
5 years, 8 months ago (2015-04-09 21:22:28 UTC) #4
eseidel
5 years, 8 months ago (2015-04-09 21:22:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b1a68e484d9ab76b85363eddb8e797d232e95964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698