Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: sky/engine/core/css/resolver/StyleBuilderConverter.cpp

Issue 1070263002: remove CSS quotes property (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/sky/engine/core/css/resolver/StyleBuilderConverter.cpp b/sky/engine/core/css/resolver/StyleBuilderConverter.cpp
index 5ae6206bda9f32c475ca2ed7fcb5b155f03af95c..36683d01e759bd8bac1df3ffdb8055e58c7ee338 100644
--- a/sky/engine/core/css/resolver/StyleBuilderConverter.cpp
+++ b/sky/engine/core/css/resolver/StyleBuilderConverter.cpp
@@ -209,24 +209,6 @@ float StyleBuilderConverter::convertNumberOrPercentage(StyleResolverState& state
return primitiveValue->getFloatValue() / 100.0f;
}
-PassRefPtr<QuotesData> StyleBuilderConverter::convertQuotes(StyleResolverState&, CSSValue* value)
-{
- if (value->isValueList()) {
- CSSValueList* list = toCSSValueList(value);
- RefPtr<QuotesData> quotes = QuotesData::create();
- for (size_t i = 0; i < list->length(); i += 2) {
- CSSValue* first = list->item(i);
- CSSValue* second = list->item(i + 1);
- String startQuote = toCSSPrimitiveValue(first)->getStringValue();
- String endQuote = toCSSPrimitiveValue(second)->getStringValue();
- quotes->addPair(std::make_pair(startQuote, endQuote));
- }
- return quotes.release();
- }
- // FIXME: We should assert we're a primitive value with valueID = CSSValueNone
- return QuotesData::create();
-}
-
LengthSize StyleBuilderConverter::convertRadius(StyleResolverState& state, CSSValue* value)
{
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
« no previous file with comments | « sky/engine/core/css/resolver/StyleBuilderConverter.h ('k') | sky/engine/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698