Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1070213003: Add GM to test non-AA pixel snapping for points, lines, rects. (Closed)

Created:
5 years, 8 months ago by bsalomon
Modified:
5 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GM to test non-AA pixel snapping for points, lines, rects. Committed: https://skia.googlesource.com/skia/+/87cbcf3f86a58cacab2e576ebc0e29399a1d48b3

Patch Set 1 #

Patch Set 2 : remove unnecessary bmp members #

Patch Set 3 : remove SkShader.h #

Total comments: 6

Patch Set 4 : add SkShader.h back #

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -0 lines) Patch
A gm/pixelsnap.cpp View 1 2 3 4 1 chunk +191 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
bsalomon
5 years, 8 months ago (2015-04-22 14:52:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070213003/40001
5 years, 8 months ago (2015-04-22 14:52:46 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/440) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 8 months ago (2015-04-22 15:00:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070213003/60001
5 years, 8 months ago (2015-04-22 15:23:36 UTC) #8
robertphillips
lgtm + nits https://codereview.chromium.org/1070213003/diff/40001/gm/pixelsnap.cpp File gm/pixelsnap.cpp (right): https://codereview.chromium.org/1070213003/diff/40001/gm/pixelsnap.cpp#newcode33 gm/pixelsnap.cpp:33: int yoffset = SkScalarCeilToInt(labelPaint.getTextSize()); "+( " ...
5 years, 8 months ago (2015-04-22 15:28:12 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-22 15:28:50 UTC) #11
bsalomon
https://codereview.chromium.org/1070213003/diff/40001/gm/pixelsnap.cpp File gm/pixelsnap.cpp (right): https://codereview.chromium.org/1070213003/diff/40001/gm/pixelsnap.cpp#newcode33 gm/pixelsnap.cpp:33: int yoffset = SkScalarCeilToInt(labelPaint.getTextSize()); On 2015/04/22 15:28:11, robertphillips wrote: ...
5 years, 8 months ago (2015-04-22 15:46:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070213003/80001
5 years, 8 months ago (2015-04-22 15:46:08 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 15:51:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/87cbcf3f86a58cacab2e576ebc0e29399a1d48b3

Powered by Google App Engine
This is Rietveld 408576698