Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: gm/pixelsnap.cpp

Issue 1070213003: Add GM to test non-AA pixel snapping for points, lines, rects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/gmslides.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/pixelsnap.cpp
diff --git a/gm/pixelsnap.cpp b/gm/pixelsnap.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..a9652f6f870082faeb0e65b95ccb89d6ec74b7d4
--- /dev/null
+++ b/gm/pixelsnap.cpp
@@ -0,0 +1,191 @@
+/*
+ * Copyright 2015 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "gm.h"
+
+#include "SkShader.h"
+
+// This class of GMs test how edges/verts snap near rounding boundaries in device space without
+// anti-aliaing.
+class PixelSnapGM : public skiagm::GM {
+public:
+ PixelSnapGM() {}
+
+protected:
+ // kTrans should be even or checkboards wont agree in different test cases.
+ static const int kTrans = 14;
+ static const int kLabelPad = 4;
+ // The inverse of this value should be a perfect SkScalar.
+ static const int kSubPixelSteps = 8;
+ static const int kLabelTextSize = 9;
+
+ SkISize onISize() override {
+ SkPaint labelPaint;
+ labelPaint.setAntiAlias(true);
+ labelPaint.setColor(SK_ColorWHITE);
+ labelPaint.setTextSize(SkIntToScalar(kLabelTextSize));
+ // Assert that we only render double digit labels
+ SkASSERT(kSubPixelSteps < 99);
+ // Pick 88 as widest possible label rendered (?)
+ int xoffset = SkScalarCeilToInt(labelPaint.measureText("88", 2));
+ int yoffset = SkScalarCeilToInt(labelPaint.getTextSize());
+ return SkISize::Make(kLabelPad + (kSubPixelSteps + 1) * kTrans + xoffset,
+ kLabelPad + (kSubPixelSteps + 1) * kTrans + yoffset);
+ }
+
+ void onDraw(SkCanvas* canvas) override {
+ SkPaint bgPaint;
+ bgPaint.setShader(
+ sk_tool_utils::create_checkerboard_shader(0xFFAAAAAA, 0xFF777777, 1))->unref();
+ canvas->drawPaint(bgPaint);
+
+ SkString offset;
+ SkPaint labelPaint;
+ labelPaint.setAntiAlias(true);
+ labelPaint.setColor(SK_ColorWHITE);
+ labelPaint.setTextSize(SkIntToScalar(kLabelTextSize));
+ SkPaint linePaint;
+ linePaint.setColor(SK_ColorWHITE);
+
+ // Draw row labels
+ static const SkScalar labelOffsetY = labelPaint.getTextSize() + kLabelPad;
+ SkScalar labelOffsetX = 0;
+ canvas->save();
+ canvas->translate(0, labelOffsetY);
+ for (int i = 0; i <= kSubPixelSteps; ++i) {
+ offset.printf("%d", i);
+ canvas->drawText(offset.c_str(), offset.size(),
+ 0, i * kTrans + labelPaint.getTextSize(),
+ labelPaint);
+ labelOffsetX = SkTMax(labelPaint.measureText(offset.c_str(), offset.size()),
+ labelOffsetX);
+ }
+ canvas->restore();
+ labelOffsetX += kLabelPad;
+ labelOffsetX = SkScalarCeilToScalar(labelOffsetX);
+
+ // Draw col labels
+ canvas->save();
+ canvas->translate(labelOffsetX, 0);
+ for (int i = 0; i <= kSubPixelSteps; ++i) {
+ offset.printf("%d", i);
+ canvas->drawText(offset.c_str(), offset.size(),
+ i * SkIntToScalar(kTrans), labelPaint.getTextSize(),
+ labelPaint);
+ }
+ canvas->restore();
+
+ canvas->translate(labelOffsetX, labelOffsetY);
+ SkASSERT((SkScalar)(int)labelOffsetX == labelOffsetX);
+ SkASSERT((SkScalar)(int)labelOffsetY == labelOffsetY);
+
+ // Draw test case grid lines (Draw them all at pixel centers to hopefully avoid any
+ // snapping issues).
+ for (int i = 0; i <= kSubPixelSteps + 1; ++i) {
+ canvas->drawLine(0.5f,
+ i * SkIntToScalar(kTrans) + 0.5f,
+ SkIntToScalar(kTrans) * (kSubPixelSteps + 1) + 0.5f,
+ i * SkIntToScalar(kTrans) + 0.5f,
+ linePaint);
+ canvas->drawLine(i * SkIntToScalar(kTrans) + 0.5f,
+ 0.5f,
+ i * SkIntToScalar(kTrans) + 0.5f,
+ SkIntToScalar(kTrans) * (kSubPixelSteps + 1) + 0.5f,
+ linePaint);
+ }
+
+ for (int i = 0; i <= kSubPixelSteps; ++i) {
+ for (int j = 0; j <= kSubPixelSteps; ++j) {
+ canvas->save();
+ // +1's account for the grid lines around each test case.
+ canvas->translate(j * (kTrans + 1.f/kSubPixelSteps) + 1,
+ i * (kTrans + 1.f/kSubPixelSteps) + 1);
+ this->drawElement(canvas);
+ canvas->restore();
+ }
+ }
+ }
+
+ virtual void drawElement(SkCanvas*) = 0;
+
+private:
+ typedef skiagm::GM INHERITED;
+};
+
+class PointSnapGM : public PixelSnapGM {
+protected:
+ SkString onShortName() override { return SkString("pixel_snap_point"); }
+ void drawElement(SkCanvas* canvas) override { canvas->drawPoint(1, 1, SK_ColorBLUE); }
+
+private:
+ typedef PixelSnapGM INHERITED;
+};
+
+class LineSnapGM : public PixelSnapGM {
+protected:
+ SkString onShortName() override { return SkString("pixel_snap_line"); }
+ void drawElement(SkCanvas* canvas) override {
+ SkPaint paint;
+ paint.setColor(SK_ColorGREEN);
+ // Draw a horizontal and vertical line, each length 3.
+ canvas->drawLine(1, 1, 4, 1, paint);
+ canvas->drawLine(6, 1, 6, 4, paint);
+ }
+
+private:
+ typedef PixelSnapGM INHERITED;
+};
+
+class RectSnapGM : public PixelSnapGM {
+protected:
+ SkString onShortName() override { return SkString("pixel_snap_rect"); }
+ void drawElement(SkCanvas* canvas) override {
+ SkPaint paint;
+ paint.setColor(SK_ColorRED);
+ canvas->drawRect(SkRect::MakeXYWH(1, 1, 3, 3), paint);
+ }
+
+private:
+ typedef PixelSnapGM INHERITED;
+};
+
+class ComboSnapGM : public PixelSnapGM {
+protected:
+ SkString onShortName() override { return SkString("pixel_snap_combo"); }
+ void drawElement(SkCanvas* canvas) override {
+ SkPaint paint;
+ paint.setAntiAlias(false);
+ // A rectangle that exactly covers a pixel, a point at each corner, 8 horiz/vert lines
+ // at rect corners (two at each corner, extending away from rect). They are drawn in this
+ // order lines (green), points (blue), rect(red).
+ SkRect rect = SkRect::MakeXYWH(3, 3, 1, 1);
+ paint.setColor(SK_ColorGREEN);
+ canvas->drawLine(3, 3, 0, 3, paint);
+ canvas->drawLine(3, 3, 3, 0, paint);
+ canvas->drawLine(4, 3, 7, 3, paint);
+ canvas->drawLine(4, 3, 4, 0, paint);
+ canvas->drawLine(3, 4, 0, 4, paint);
+ canvas->drawLine(3, 4, 3, 7, paint);
+ canvas->drawLine(4, 4, 7, 4, paint);
+ canvas->drawLine(4, 4, 4, 7, paint);
+ canvas->drawPoint(4, 3, SK_ColorBLUE);
+ canvas->drawPoint(4, 4, SK_ColorBLUE);
+ canvas->drawPoint(3, 3, SK_ColorBLUE);
+ canvas->drawPoint(3, 4, SK_ColorBLUE);
+ paint.setColor(SK_ColorRED);
+ canvas->drawRect(rect, paint);
+ }
+
+private:
+ typedef PixelSnapGM INHERITED;
+};
+
+//////////////////////////////////////////////////////////////////////////////
+DEF_GM( return SkNEW(PointSnapGM); )
+DEF_GM( return SkNEW(LineSnapGM); )
+DEF_GM( return SkNEW(RectSnapGM); )
+DEF_GM( return SkNEW(ComboSnapGM); )
« no previous file with comments | « no previous file | gyp/gmslides.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698