Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1069903002: Update gn_all, gyp_remaining for chromeos. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gn_all, gyp_remaining for chromeos. This involves restructuring the remoting conditionals in gn_all and gyp_remaining a fair amount, but otherwise no real surprises here. There are a few chromeos-specific unittest targets in content that we still need to port, but otherwise the port is as complete as desktop linux. BUG=433082 Committed: https://crrev.com/6293d2503965332696a292ff8a8da0a8f2a7ecc5 Cr-Commit-Position: refs/heads/master@{#325097}

Patch Set 1 #

Patch Set 2 : merge to #324972 #

Patch Set 3 : fix symupload merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -57 lines) Patch
M BUILD.gn View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 14 chunks +74 lines, -51 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dirk Pranke
This patch depends on the win gn_all/gyp_remaining patch that was reverted, so it won't work ...
5 years, 8 months ago (2015-04-09 02:50:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069903002/40001
5 years, 8 months ago (2015-04-14 02:37:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56094)
5 years, 8 months ago (2015-04-14 02:45:19 UTC) #5
tfarina
lgtm
5 years, 8 months ago (2015-04-14 13:40:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069903002/40001
5 years, 8 months ago (2015-04-14 17:20:22 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-14 19:12:12 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 19:13:36 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6293d2503965332696a292ff8a8da0a8f2a7ecc5
Cr-Commit-Position: refs/heads/master@{#325097}

Powered by Google App Engine
This is Rietveld 408576698