Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: BUILD.gn

Issue 1069903002: Update gn_all, gyp_remaining for chromeos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix symupload merge Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 91763004b3ae1e95e54c5dcd72ce8faff8a6f2bc..2cdb190a451e91cbc435554b57581945fb83f2a0 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -284,6 +284,13 @@ group("gn_all") {
]
}
+ if (is_chromeos) {
+ deps += [
+ "//chromeos:chromeos_unittests",
+ "//ui/chromeos:ui_chromeos_unittests",
+ ]
+ }
+
if (is_chromeos || is_mac || is_win) {
deps += [
"//rlz:rlz_id",
@@ -547,11 +554,8 @@ group("gn_all") {
"//crypto:crypto_unittests", # TODO(GYP)
"//net:net_unittests", # TODO(GYP)
]
- } else {
- if (!is_android) {
- # TODO(GYP): Make this work on android also.
- deps += [ "//breakpad:symupload" ]
- }
+ } else if (!is_android) {
+ deps += [ "//breakpad:symupload" ]
}
}
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698