Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1069833002: Use analyzer 0.24.3: now that our changes are integrated into analyzer, we can (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 8 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use analyzer 0.24.3: now that our changes are integrated into analyzer, we can simply use the latest release of analyser. Woo hoo! R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/29fb79e7356fa22fe2e1cae92b283a41aa6f8905

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M lib/src/codegen/reify_coercions.dart View 1 chunk +0 lines, -1 line 1 comment Download
M pubspec.yaml View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1069833002/diff/1/lib/src/codegen/reify_coercions.dart File lib/src/codegen/reify_coercions.dart (left): https://codereview.chromium.org/1069833002/diff/1/lib/src/codegen/reify_coercions.dart#oldcode604 lib/src/codegen/reify_coercions.dart:604: assert(type is! UnionType); UnionType was deleted in 0.24.3
5 years, 8 months ago (2015-04-08 20:58:55 UTC) #2
Jennifer Messerly
lgtm
5 years, 8 months ago (2015-04-08 21:06:45 UTC) #3
vsm
lgtm! Do you know what svn rev this corresponds to? Wondering if it has: https://codereview.chromium.org/1069473002/
5 years, 8 months ago (2015-04-08 21:07:34 UTC) #4
Siggi Cherem (dart-lang)
Yes, I believe it does. I first rolled this on our ddc_analyzer repo to validate ...
5 years, 8 months ago (2015-04-08 21:10:46 UTC) #5
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-08 21:11:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29fb79e7356fa22fe2e1cae92b283a41aa6f8905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698