Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1069473002: Provide access to list of types that cannot be subtyped (issue 23125) (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
vsm, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Provide access to list of types that cannot be subtyped (issue 23125) R=paulberry@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44972

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -40 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +16 lines, -32 lines 1 comment Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
Suggestions for a better name are welcome.
5 years, 8 months ago (2015-04-07 20:46:06 UTC) #2
vsm
thanks! lgtm https://codereview.chromium.org/1069473002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1069473002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode13273 pkg/analyzer/lib/src/generated/resolver.dart:13273: List<InterfaceType> get nonSubtypableTypes; sealedTypes is another option
5 years, 8 months ago (2015-04-07 20:51:12 UTC) #3
Paul Berry
lgtm. I don't have a strong opinion on the name.
5 years, 8 months ago (2015-04-08 16:06:57 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as 44972 (presubmit successful).
5 years, 8 months ago (2015-04-08 16:11:12 UTC) #5
Brian Wilkerson
5 years, 8 months ago (2015-04-08 16:13:13 UTC) #6
Message was sent while issue was closed.
The only reference I see to "sealed" is C#, but the use there appears to be
related to inheritance rather than subtyping. I'd prefer a more general name,
but I couldn't find one in the literature.

Powered by Google App Engine
This is Rietveld 408576698