Optimize num::~/, num::>> and num::<< for some cases.

Optimize num::~/, num::>> and num::<< for some cases.

R=floitsch@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31023

[ngeoffray, 2013-12-10 14:20:47]

+sra, I know you might be interested in this :)

[kasperl, 2013-12-10 14:22:53]

LGTM.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart
(right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:233:

Too much whitespace.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:393:
instruction.selector = renameToOptimizedSelector(
Add a comment that explains what the contract for calling tdivFast is.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
File sdk/lib/_internal/lib/js_number.dart (right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
sdk/lib/_internal/lib/js_number.dart:218: num _slowTdiv(num other) {
Rename to _tdivSlow?

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
sdk/lib/_internal/lib/js_number.dart:252: // For negative numbers we just clamp
the shift-by amount. 'a' could be
a? You mean [this]?

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
sdk/lib/_internal/lib/js_number.dart:269: // Given that 'a' is positive we must
not use '>>'. Otherwise a number
a?

[ngeoffray, 2013-12-10 15:26:16]

Thanks Kasper. I also fixed a bug spotted by floitsch@ and added a regression
test.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart
(right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:233:

On 2013/12/10 14:22:54, kasperl wrote:
> Too much whitespace.

Done.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:393:
instruction.selector = renameToOptimizedSelector(
On 2013/12/10 14:22:54, kasperl wrote:
> Add a comment that explains what the contract for calling tdivFast is.

Done.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
File sdk/lib/_internal/lib/js_number.dart (right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
sdk/lib/_internal/lib/js_number.dart:218: num _slowTdiv(num other) {
On 2013/12/10 14:22:54, kasperl wrote:
> Rename to _tdivSlow?

Done.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
sdk/lib/_internal/lib/js_number.dart:252: // For negative numbers we just clamp
the shift-by amount. 'a' could be
On 2013/12/10 14:22:54, kasperl wrote:
> a? You mean [this]?

Done.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/lib/js_num...
sdk/lib/_internal/lib/js_number.dart:269: // Given that 'a' is positive we must
not use '>>'. Otherwise a number
On 2013/12/10 14:22:54, kasperl wrote:
> a?

Done.

[floitsch, 2013-12-10 15:45:16]

LGTM.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1252:
visitTruncatingDivide(HTruncatingDivide node) {
Maybe add an assert that left and right are of the right size?
This makes it clear what the preconditions are, and might even catch
regressions.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart
(right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:388:
if (right.isUInt32(compiler) && isNotZero(right, compiler)) {
Right side only needs to be an integer != 0.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:389:
if (left.isUInt32(compiler)) {
left.isUInt31, or left.isInt32

[ngeoffray, 2013-12-10 15:48:15]

Thanks Florian.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1252:
visitTruncatingDivide(HTruncatingDivide node) {
On 2013/12/10 15:45:16, floitsch wrote:
> Maybe add an assert that left and right are of the right size?
> This makes it clear what the preconditions are, and might even catch
> regressions.

Done.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart
(right):

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:388:
if (right.isUInt32(compiler) && isNotZero(right, compiler)) {
On 2013/12/10 15:45:16, floitsch wrote:
> Right side only needs to be an integer != 0.

Done.

https://codereview.chromium.org/106973008/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:389:
if (left.isUInt32(compiler)) {
On 2013/12/10 15:45:16, floitsch wrote:
> left.isUInt31, or left.isInt32

Changed to left.isUInt31 (we don't have isInt32).

[ngeoffray, 2013-12-10 15:59:28]

Committed patchset #3 manually as r31023 (presubmit successful).