Optimize num::~/, num::>> and num::<< for some cases.

sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * [InvokeDynamicSpecializer] and its subclasses are helpers to
  * optimize intercepted dynamic calls. It knows what input types
  * would be beneficial for performance, and how to change a invoke
@@ skipping 211 matching lines @@
 
   bool inputsArePositiveIntegers(HInstruction instruction, Compiler compiler) {
     HInstruction left = instruction.inputs[1];
     HInstruction right = instruction.inputs[2];
     JavaScriptBackend backend = compiler.backend;
     return left.isPositiveIntegerOrNull(compiler)
         && right.isPositiveIntegerOrNull(compiler);
   }
 
   HInstruction newBuiltinVariant(HInvokeDynamic instruction, Compiler compiler);
+
+

[kasperl, 2013/12/10 14:22:54]

Too much whitespace.

[ngeoffray, 2013/12/10 15:26:17]

Done.

+  Selector renameToOptimizedSelector(String name,
+                                     Selector selector,
+                                     Compiler compiler) {
+    if (selector.name == name) return selector;
+    return new TypedSelector(
+        selector.mask,
+        new Selector(SelectorKind.CALL,
+                     name,
+                     compiler.interceptorsLibrary,
+                     selector.argumentCount));
+  }
 }
 
 class AddSpecializer extends BinaryArithmeticSpecializer {
   const AddSpecializer();
 
   TypeMask computeTypeFromInputTypes(HInvokeDynamic instruction,
                                      Compiler compiler) {
     if (inputsArePositiveIntegers(instruction, compiler)) {
       JavaScriptBackend backend = compiler.backend;
       return backend.positiveIntType;
@@ skipping 110 matching lines @@
 
   TypeMask computeTypeFromInputTypes(HInvokeDynamic instruction,
                                      Compiler compiler) {
     if (inputsArePositiveIntegers(instruction, compiler)) {
       JavaScriptBackend backend = compiler.backend;
       return backend.positiveIntType;
     }
     return super.computeTypeFromInputTypes(instruction, compiler);
   }
 
+  bool isNotZero(HInstruction instruction, Compiler compiler) {
+    if (!instruction.isConstantInteger()) return false;
+    HConstant rightConstant = instruction;
+    IntConstant intConstant = rightConstant.constant;
+    int count = intConstant.value;
+    return count != 0;
+  }
+
+  HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,
+                                   Compiler compiler) {
+    HInstruction left = instruction.inputs[1];
+    HInstruction right = instruction.inputs[2];
+    if (isBuiltin(instruction, compiler)) {
+      if (right.isUInt32(compiler) && isNotZero(right, compiler)) {

[floitsch, 2013/12/10 15:45:16]

Right side only needs to be an integer != 0.

[ngeoffray, 2013/12/10 15:48:15]

Done.

+        if (left.isUInt32(compiler)) {

[floitsch, 2013/12/10 15:45:16]

left.isUInt31, or left.isInt32

[ngeoffray, 2013/12/10 15:48:15]

Changed to left.isUInt31 (we don't have isInt32).

+          return newBuiltinVariant(instruction, compiler);
+        }
+        clearAllSideEffects(instruction);
+        instruction.selector = renameToOptimizedSelector(

[kasperl, 2013/12/10 14:22:54]

Add a comment that explains what the contract for calling tdivFast is.

[ngeoffray, 2013/12/10 15:26:17]

Done.

+            '_tdivFast', instruction.selector, compiler);
+      }
+    }
+    return null;
+  }
+
   HInstruction newBuiltinVariant(HInvokeDynamic instruction,
                                  Compiler compiler) {
-    // Truncating divide does not have a JS equivalent.    
-    return null;
+    return new HTruncatingDivide(
+        instruction.inputs[1], instruction.inputs[2],
+        instruction.selector, computeTypeFromInputTypes(instruction, compiler));
   }
 }
 
 abstract class BinaryBitOpSpecializer extends BinaryArithmeticSpecializer {
   const BinaryBitOpSpecializer();
 
   TypeMask computeTypeFromInputTypes(HInvokeDynamic instruction,
                                      Compiler compiler) {
     // All bitwise operations on primitive types either produce an
     // integer or throw an error.
@@ skipping 32 matching lines @@
     HInstruction left = instruction.inputs[1];
     HInstruction right = instruction.inputs[2];
     if (left.isNumber(compiler)) {
       if (argumentLessThan32(right)) {
         return newBuiltinVariant(instruction, compiler);
       }
       // Even if there is no builtin equivalent instruction, we know
       // the instruction does not have any side effect, and that it
       // can be GVN'ed.
       clearAllSideEffects(instruction);
+      Selector selector = instruction.selector;
+      if (isPositive(right, compiler)) {
+        instruction.selector = renameToOptimizedSelector(
+            '_shlPositive', instruction.selector, compiler);
+      }
     }
     return null;
   }
 
   HInstruction newBuiltinVariant(HInvokeDynamic instruction,
                                  Compiler compiler) {
     JavaScriptBackend backend = compiler.backend;
     return new HShiftLeft(
         instruction.inputs[1], instruction.inputs[2],
         instruction.selector, computeTypeFromInputTypes(instruction, compiler));
@@ skipping 17 matching lines @@
     HInstruction left = instruction.inputs[1];
     HInstruction right = instruction.inputs[2];
     if (left.isNumber(compiler)) {
       if (argumentLessThan32(right) && isPositive(left, compiler)) {
         return newBuiltinVariant(instruction, compiler);
       }
       // Even if there is no builtin equivalent instruction, we know
       // the instruction does not have any side effect, and that it
       // can be GVN'ed.
       clearAllSideEffects(instruction);
+      if (isPositive(right, compiler) && isPositive(left, compiler)) {
+        instruction.selector = renameToOptimizedSelector(
+            '_shrBothPositive', instruction.selector, compiler);
+      } else if (isPositive(left, compiler) && right.isNumber(compiler)) {
+        instruction.selector = renameToOptimizedSelector(
+            '_shrReceiverPositive', instruction.selector, compiler);
+      } else if (isPositive(right, compiler)) {
+        instruction.selector = renameToOptimizedSelector(
+            '_shrOtherPositive', instruction.selector, compiler);
+      }
     }
     return null;
   }
 
   HInstruction newBuiltinVariant(HInvokeDynamic instruction,
                                  Compiler compiler) {
     JavaScriptBackend backend = compiler.backend;
     return new HShiftRight(
         instruction.inputs[1], instruction.inputs[2],
         instruction.selector, computeTypeFromInputTypes(instruction, compiler));
@@ skipping 204 matching lines @@
   }
 
   HInstruction newBuiltinVariant(HInvokeDynamic instruction,
                                  Compiler compiler) {
     JavaScriptBackend backend = compiler.backend;
     return new HLessEqual(
         instruction.inputs[1], instruction.inputs[2],
         instruction.selector, backend.boolType);
   }
 }