Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1069703002: Replace the struct workaround for forward-declaring ChromeViewHostMsg_GetPluginInfo_Status with a p… (Closed)

Created:
5 years, 8 months ago by Bernhard Bauer
Modified:
5 years, 8 months ago
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src@issue444203
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the struct workaround for forward-declaring ChromeViewHostMsg_GetPluginInfo_Status with a proper enum class. Committed: https://crrev.com/96d29c0c63677f0c67e585ee2771d1633e982155 Cr-Commit-Position: refs/heads/master@{#324399}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : update base branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -85 lines) Patch
M chrome/browser/plugins/plugin_info_message_filter.h View 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 2 11 chunks +20 lines, -23 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/render_messages.h View 2 3 chunks +12 lines, -24 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 7 chunks +14 lines, -17 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Bernhard Bauer
Please review. Thanks!
5 years, 8 months ago (2015-04-08 10:19:50 UTC) #2
Mike West
IPC LGTM.
5 years, 8 months ago (2015-04-08 10:32:45 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-08 15:21:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069703002/1
5 years, 8 months ago (2015-04-08 16:19:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/53375)
5 years, 8 months ago (2015-04-08 17:49:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069703002/20001
5 years, 8 months ago (2015-04-09 07:27:22 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 8 months ago (2015-04-09 07:27:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069703002/40001
5 years, 8 months ago (2015-04-09 07:43:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069703002/40001
5 years, 8 months ago (2015-04-09 07:47:19 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 08:40:45 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 08:41:31 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/96d29c0c63677f0c67e585ee2771d1633e982155
Cr-Commit-Position: refs/heads/master@{#324399}

Powered by Google App Engine
This is Rietveld 408576698