Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 1069703002: Replace the struct workaround for forward-declaring ChromeViewHostMsg_GetPluginInfo_Status with a p… (Closed) Base URL: https://chromium.googlesource.com/chromium/src@issue444203
Patch Set: update base branch Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/chrome_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h
index d7ecf76a3df2f7601239af645e3d873f139cec6c..c308732dc1e38b5202a640d3b6d5859939ecfc13 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.h
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h
@@ -13,7 +13,7 @@ namespace gfx {
class Size;
}
-struct ChromeViewHostMsg_GetPluginInfo_Status;
+enum class ChromeViewHostMsg_GetPluginInfo_Status;
// This contains information specifying the poster image of plugin placeholders.
// The default constructor specifies no poster image.
@@ -55,7 +55,7 @@ class ChromePluginPlaceholder : public plugins::LoadablePluginPlaceholder,
content::RenderFrame* render_frame,
const base::FilePath& plugin_path);
- void SetStatus(const ChromeViewHostMsg_GetPluginInfo_Status& status);
+ void SetStatus(ChromeViewHostMsg_GetPluginInfo_Status status);
#if defined(ENABLE_PLUGIN_INSTALLATION)
int32 CreateRoutingId();
@@ -101,9 +101,7 @@ class ChromePluginPlaceholder : public plugins::LoadablePluginPlaceholder,
void OnCancelledDownloadingPlugin();
#endif
- // We use a scoped_ptr so we can forward-declare the struct; it's defined in
- // an IPC message file which can't be easily included in other header files.
- scoped_ptr<ChromeViewHostMsg_GetPluginInfo_Status> status_;
+ ChromeViewHostMsg_GetPluginInfo_Status status_;
base::string16 title_;
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client_browsertest.cc ('k') | chrome/renderer/plugins/chrome_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698