upstream SurfaceTextureListener and SurfaceTextureBridge class for android

upstream SurfaceTextureListener and SurfaceTextureBridge class for android


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145213

[Yaron, 2012-06-27 23:50:14]

What about adding the hook that reaches into this code?

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
File content/common/android/surface_texture_listener.cc (right):

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
content/common/android/surface_texture_listener.cc:49: return ret;
Nit: return RegisterNativesImpl(env);

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
File content/common/android/surface_texture_listener.h (right):

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
content/common/android/surface_texture_listener.h:7: 
#pragma once

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
content/common/android/surface_texture_listener.h:47: bool
RegisterSurfaceTextureListener(JNIEnv* env);
Nit: make this a static member of SurfaceTextureListener

http://codereview.chromium.org/10695020/diff/1/content/public/android/java/sr...
File
content/public/android/java/src/org/chromium/content/common/SurfaceTextureListener.java
(right):

http://codereview.chromium.org/10695020/diff/1/content/public/android/java/sr...
content/public/android/java/src/org/chromium/content/common/SurfaceTextureListener.java:12:
// Listener to an android SurfaceTexture object for frame availability.
Switch to javadoc

[qinmin, 2012-06-28 02:24:55]

added streamTextureManagerAndroid class where SurfaceTextureBridge is being
used.

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
File content/common/android/surface_texture_listener.cc (right):

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
content/common/android/surface_texture_listener.cc:49: return ret;
On 2012/06/27 23:50:14, Yaron wrote:
> Nit: return RegisterNativesImpl(env);

Done.

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
File content/common/android/surface_texture_listener.h (right):

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
content/common/android/surface_texture_listener.h:7: 
On 2012/06/27 23:50:14, Yaron wrote:
> #pragma once

Done.

http://codereview.chromium.org/10695020/diff/1/content/common/android/surface...
content/common/android/surface_texture_listener.h:47: bool
RegisterSurfaceTextureListener(JNIEnv* env);
On 2012/06/27 23:50:14, Yaron wrote:
> Nit: make this a static member of SurfaceTextureListener

Done.

http://codereview.chromium.org/10695020/diff/1/content/public/android/java/sr...
File
content/public/android/java/src/org/chromium/content/common/SurfaceTextureListener.java
(right):

http://codereview.chromium.org/10695020/diff/1/content/public/android/java/sr...
content/public/android/java/src/org/chromium/content/common/SurfaceTextureListener.java:12:
// Listener to an android SurfaceTexture object for frame availability.
On 2012/06/27 23:50:14, Yaron wrote:
> Switch to javadoc

Done.

[Yaron, 2012-06-28 02:53:06]

http://codereview.chromium.org/10695020/diff/7001/content/common/gpu/stream_t...
File content/common/gpu/stream_texture_manager_android.cc (right):

http://codereview.chromium.org/10695020/diff/7001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.cc:14: NOTIMPLEMENTED();
Why all the NOTIMPLEMENTEDS? Still more to refactor before landing?

[qinmin, 2012-06-28 03:23:21]

http://codereview.chromium.org/10695020/diff/7001/content/common/gpu/stream_t...
File content/common/gpu/stream_texture_manager_android.cc (right):

http://codereview.chromium.org/10695020/diff/7001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.cc:14: NOTIMPLEMENTED();
I don't want this change to get too big to review. Right now the change is good
to go, the NOTIMPLEMENTED() stuff can be upstreamed later as we don't have too
much dependencies on them

On 2012/06/28 02:53:06, Yaron wrote:
> Why all the NOTIMPLEMENTEDS? Still more to refactor before landing?

[Yaron, 2012-06-28 16:02:21]

lgtm

Ok, fair enough. My main motivation was to get this to the point of reaching
shared content/chrome code to ensure that the interface makes sense but I guess
we have to break this up in pieces.

[jam, 2012-06-28 23:12:25]

lgtm

http://codereview.chromium.org/10695020/diff/7001/content/app/android/content...
File content/app/android/content_jni_registrar.cc (right):

http://codereview.chromium.org/10695020/diff/7001/content/app/android/content...
content/app/android/content_jni_registrar.cc:41:
content::SurfaceTextureListener::RegisterSurfaceTextureListener },
nit: 4 space indent

http://codereview.chromium.org/10695020/diff/7001/content/common/gpu/stream_t...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695020/diff/7001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.h:22: class
StreamTextureManagerAndroid : public gpu::StreamTextureManager {
nit: put this in content namespace as well

[qinmin, 2012-06-28 23:57:25]

https://chromiumcodereview.appspot.com/10695020/diff/7001/content/app/android...
File content/app/android/content_jni_registrar.cc (right):

https://chromiumcodereview.appspot.com/10695020/diff/7001/content/app/android...
content/app/android/content_jni_registrar.cc:41:
content::SurfaceTextureListener::RegisterSurfaceTextureListener },
On 2012/06/28 23:12:26, John Abd-El-Malek wrote:
> nit: 4 space indent

Done.

https://chromiumcodereview.appspot.com/10695020/diff/7001/content/common/gpu/...
File content/common/gpu/stream_texture_manager_android.h (right):

https://chromiumcodereview.appspot.com/10695020/diff/7001/content/common/gpu/...
content/common/gpu/stream_texture_manager_android.h:22: class
StreamTextureManagerAndroid : public gpu::StreamTextureManager {
On 2012/06/28 23:12:26, John Abd-El-Malek wrote:
> nit: put this in content namespace as well

Done.

[qinmin, 2012-06-29 00:19:28]

@jrg, John, would you please take a look?

On 2012/06/28 23:57:25, qinmin wrote:
>
https://chromiumcodereview.appspot.com/10695020/diff/7001/content/app/android...
> File content/app/android/content_jni_registrar.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10695020/diff/7001/content/app/android...
> content/app/android/content_jni_registrar.cc:41:
> content::SurfaceTextureListener::RegisterSurfaceTextureListener },
> On 2012/06/28 23:12:26, John Abd-El-Malek wrote:
> > nit: 4 space indent
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10695020/diff/7001/content/common/gpu/...
> File content/common/gpu/stream_texture_manager_android.h (right):
> 
>
https://chromiumcodereview.appspot.com/10695020/diff/7001/content/common/gpu/...
> content/common/gpu/stream_texture_manager_android.h:22: class
> StreamTextureManagerAndroid : public gpu::StreamTextureManager {
> On 2012/06/28 23:12:26, John Abd-El-Malek wrote:
> > nit: put this in content namespace as well
> 
> Done.

[jam, 2012-07-02 17:54:06]

lgtm with nits

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
File content/common/gpu/stream_texture_manager_android.cc (right):

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
content/common/gpu/stream_texture_manager_android.cc:14: : surface_texture_(new
content::SurfaceTextureBridge(service_id)),
nit: ditto

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
content/common/gpu/stream_texture_manager_android.h:44:
content::SurfaceTextureBridge* bridge()
nit: here and below, get rid of "content::"

[qinmin, 2012-07-02 19:29:50]

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
File content/common/gpu/stream_texture_manager_android.cc (right):

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
content/common/gpu/stream_texture_manager_android.cc:14: : surface_texture_(new
content::SurfaceTextureBridge(service_id)),
On 2012/07/02 17:54:06, John Abd-El-Malek wrote:
> nit: ditto

Done.

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695020/diff/14002/content/common/gpu/stream_...
content/common/gpu/stream_texture_manager_android.h:44:
content::SurfaceTextureBridge* bridge()
On 2012/07/02 17:54:06, John Abd-El-Malek wrote:
> nit: here and below, get rid of "content::"

Done.

[Jay Civelli, 2012-07-02 20:48:09]

base/android LGTM

[commit-bot: I haz the power, 2012-07-02 20:49:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10695020/17001

[commit-bot: I haz the power, 2012-07-02 21:28:23]

Try job failure for 10695020-17001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-02 21:36:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10695020/17001

[commit-bot: I haz the power, 2012-07-02 23:03:47]

Change committed as 145213