src/core/SkValidatingReadBuffer.h - Issue 106943002: Fixed a few places where uninitialized memory could have been read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkValidatingReadBuffer.h

Issue 106943002: Fixed a few places where uninitialized memory could have been read (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Removed bad scalar checks in SkColorMatrixFilter.cpp Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkValidatingReadBuffer.h

diff --git a/src/core/SkValidatingReadBuffer.h b/src/core/SkValidatingReadBuffer.h

index 2bcdc43e8b03358c06d58793084baa810c87fe84..febf0c0b42f9f3f6bac17cbc9075dfac54609d8e 100644

--- a/src/core/SkValidatingReadBuffer.h

+++ b/src/core/SkValidatingReadBuffer.h

@@ -61,6 +61,7 @@ public:

virtual SkTypeface* readTypeface() SK_OVERRIDE;

virtual bool validate(bool isValid) SK_OVERRIDE;

+ virtual bool isValid() const SK_OVERRIDE;

private:

bool readArray(void* value, size_t size, size_t elementSize);