src/core/SkValidatingReadBuffer.cpp - Issue 106943002: Fixed a few places where uninitialized memory could have been read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkValidatingReadBuffer.cpp

Issue 106943002: Fixed a few places where uninitialized memory could have been read (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Removed bad scalar checks in SkColorMatrixFilter.cpp Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkValidatingReadBuffer.cpp

diff --git a/src/core/SkValidatingReadBuffer.cpp b/src/core/SkValidatingReadBuffer.cpp

index 4a8ac472472fcbd0edcc77a1d4021ac164df5c9b..692d0dd4d18c83b0f7f5bd13e0bc229ba478253a 100644

--- a/src/core/SkValidatingReadBuffer.cpp

+++ b/src/core/SkValidatingReadBuffer.cpp

@@ -29,6 +29,10 @@ bool SkValidatingReadBuffer::validate(bool isValid) {

return !fError;

}

+bool SkValidatingReadBuffer::isValid() const {

+ return !fError;

void SkValidatingReadBuffer::setMemory(const void* data, size_t size) {

this->validate(IsPtrAlign4(data) && (SkAlign4(size) == size));

if (!fError) {