Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1069183002: ui: Remove the canvas() member from PaintContext. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, enne (OOO), piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Remove the canvas() member from PaintContext. The canvas() is now only accessed through the Recorder classes (ie. PaintRecorder and friends). Now we can put a DisplayItemList instead of a Canvas inside PaintContext. R=piman@chromium.org BUG=466426 Committed: https://crrev.com/a002bde549dd2edf1a5c1487c3711730937edf52 Cr-Commit-Position: refs/heads/master@{#324210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M ui/compositor/clip_transform_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositing_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/paint_context.h View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/compositor/paint_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 8 months ago (2015-04-07 23:10:09 UTC) #1
piman
lgtm
5 years, 8 months ago (2015-04-07 23:19:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069183002/1
5 years, 8 months ago (2015-04-08 08:06:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 10:53:46 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 10:54:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a002bde549dd2edf1a5c1487c3711730937edf52
Cr-Commit-Position: refs/heads/master@{#324210}

Powered by Google App Engine
This is Rietveld 408576698