Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: ui/compositor/paint_context.h

Issue 1069183002: ui: Remove the canvas() member from PaintContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/compositing_recorder.cc ('k') | ui/compositor/paint_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/paint_context.h
diff --git a/ui/compositor/paint_context.h b/ui/compositor/paint_context.h
index 914f9a9f04ca3ac3393b6cc280af8c0510827173..1d899c5ad1280212b2dc762521b427d42982ce37 100644
--- a/ui/compositor/paint_context.h
+++ b/ui/compositor/paint_context.h
@@ -13,6 +13,8 @@ class Canvas;
}
namespace ui {
+class ClipTransformRecorder;
+class CompositingRecorder;
class PaintRecorder;
class PaintContext {
@@ -43,9 +45,6 @@ class PaintContext {
return PaintContext(canvas_);
}
- // TODO(danakj): Remove this once everything is painting to display lists.
- gfx::Canvas* canvas() const { return canvas_; }
-
// When true, IsRectInvalidated() can be called, otherwise its result would be
// invalid.
bool CanCheckInvalidated() const { return !invalidation_.IsEmpty(); }
@@ -70,9 +69,11 @@ class PaintContext {
const gfx::Rect& InvalidationForTesting() const { return invalidation_; }
private:
- // The PaintRecorder needs access to the internal canvas and friends, but we
+ // The Recorder classes need access to the internal canvas and friends, but we
// don't want to expose them on this class so that people must go through the
- // recorder to access them.
+ // recorders to access them.
+ friend class ClipTransformRecorder;
+ friend class CompositingRecorder;
friend class PaintRecorder;
// Clone a PaintContext with an additional |offset|.
« no previous file with comments | « ui/compositor/compositing_recorder.cc ('k') | ui/compositor/paint_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698