Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1069043002: Fix rare browser crash when closing the Origin Info Bubble. (Closed)

Created:
5 years, 8 months ago by palmer
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix rare browser crash when closing the Origin Info Bubble. BUG=468201 TEST=Follow the repro steps in the bug and ensure there's no crash. Committed: https://crrev.com/edd17a1c50939a325590c6061c14da17690fb71e Cr-Commit-Position: refs/heads/master@{#324102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
palmer
Does your fix LGTY? :)
5 years, 8 months ago (2015-04-07 18:48:36 UTC) #2
Robert Sesek
LGTM
5 years, 8 months ago (2015-04-07 18:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069043002/1
5 years, 8 months ago (2015-04-07 18:58:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 20:10:39 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 20:11:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edd17a1c50939a325590c6061c14da17690fb71e
Cr-Commit-Position: refs/heads/master@{#324102}

Powered by Google App Engine
This is Rietveld 408576698