chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm - Issue 1069043002: Fix rare browser crash when closing the Origin Info Bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 1069043002: Fix rare browser crash when closing the Origin Info Bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

index f85e8fe956e8ec1093478b6054ae79bf59045d58..5306b1e6178b167c0472501e7036c08ab67cdb02 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

@@ -367,6 +367,7 @@ NSColor* IdentityVerifiedTextColor() {

- (void)windowWillClose:(NSNotification*)notification {

if (presenter_.get())

presenter_->OnUIClosing();

+ presenter_.reset();

[super windowWillClose:notification];

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »