Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 106903003: Revert 163043 "Move popular DOM attributes to prorotype chains" (Closed)

Created:
7 years ago by dharani1
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert 163043 "Move popular DOM attributes to prorotype chains" This is to fix bug 325744 on 1728 branch. > Move popular DOM attributes to prorotype chains > > Design document: https://docs.google.com/a/google.com/document/d/1yeHTCHhulVIlrKyx9_gCguAhLfcefVOa9uxxfW2LVG0/edit > > Intent-to-ship-and-implement in blink-dev: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/t0XiZuMey7M/9-5AuhoFyisJ > > BUG=43394 > > > This CL moves DOM attributes used in Dromaeo to prototype chains. As explained in the document, this CL is going to regress performance of Dromaeo by 8.7%. > > Dromaeo/dom-attr 1134 runs/sec => 1145 runs/sec (+1.0%) > Dromaeo/dom-modify 488 runs/sec => 493 runs/sec (+1.0%) > Dromaeo/dom-query 22860 runs/sec => 21772 runs/sec (-5.0%) > Dromaeo/dom-traverse 523 runs/sec => 481 runs/sec (-8.7%) > > See the design document and the Intent-to-ship email for justification for the regression. > > I'm going to land this CL and see how much regression is observed in perf bots (I'll email to perf-sheriff@). If I find that the regression is unacceptable, I'll revert the CL. > > Review URL: https://codereview.chromium.org/94403002 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -35 lines) Patch
D LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/dom-attribute-on-prototype-chain-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/inspector/console/console-dir-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/NodeList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dharani1
7 years ago (2013-12-05 18:52:34 UTC) #1
dharani1
7 years ago (2013-12-05 18:52:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r163280.

Powered by Google App Engine
This is Rietveld 408576698