DescriptionRevert 163043 "Move popular DOM attributes to prorotype chains"
This is to fix bug 325744 on 1728 branch.
> Move popular DOM attributes to prorotype chains
>
> Design document: https://docs.google.com/a/google.com/document/d/1yeHTCHhulVIlrKyx9_gCguAhLfcefVOa9uxxfW2LVG0/edit
>
> Intent-to-ship-and-implement in blink-dev: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/t0XiZuMey7M/9-5AuhoFyisJ
>
> BUG=43394
>
>
> This CL moves DOM attributes used in Dromaeo to prototype chains. As explained in the document, this CL is going to regress performance of Dromaeo by 8.7%.
>
> Dromaeo/dom-attr 1134 runs/sec => 1145 runs/sec (+1.0%)
> Dromaeo/dom-modify 488 runs/sec => 493 runs/sec (+1.0%)
> Dromaeo/dom-query 22860 runs/sec => 21772 runs/sec (-5.0%)
> Dromaeo/dom-traverse 523 runs/sec => 481 runs/sec (-8.7%)
>
> See the design document and the Intent-to-ship email for justification for the regression.
>
> I'm going to land this CL and see how much regression is observed in perf bots (I'll email to perf-sheriff@). If I find that the regression is unacceptable, I'll revert the CL.
>
> Review URL: https://codereview.chromium.org/94403002
TBR=haraken@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163280
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|