chrome/test/mini_installer/verifier.py - Issue 1069003002: Test app launcher registration in test_installer rather than InstallationValidator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer/verifier.py

Issue 1069003002: Test app launcher registration in test_installer rather than InstallationValidator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/mini_installer/verifier.py

diff --git a/chrome/test/mini_installer/verifier.py b/chrome/test/mini_installer/verifier.py

index f3e930e24ff087184a1ccba6b2658872d6e213fa..053096b4a807805a8f8d90a0445900cdb1ac5c6c 100644

--- a/chrome/test/mini_installer/verifier.py

+++ b/chrome/test/mini_installer/verifier.py

@@ -49,4 +49,4 @@ class Verifier:

Returns:

The result of the evaluated condition.

"""

- return eval(condition, {'__builtins__': None}, None)

+ return eval(condition, {'__builtins__': {'False': False, 'True': True}})

gab 2015/04/08 14:28:29 This change looks like it makes sense to me, but I

grt (UTC plus 2) 2015/04/08 14:35:40 Prior to this change, $SUPPORTS_SXS wasn't evaluat

« chrome/test/mini_installer/config/chrome_system_installed.prop ('K') | « chrome/test/mini_installer/variable_expander.py ('k') | no next file » | no next file with comments »