chrome/test/mini_installer/config/chrome_system_installed.prop - Issue 1069003002: Test app launcher registration in test_installer rather than InstallationValidator.

Unified Diff: chrome/test/mini_installer/config/chrome_system_installed.prop

Issue 1069003002: Test app launcher registration in test_installer rather than InstallationValidator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/installation_validator.cc ('k') | chrome/test/mini_installer/config/chrome_system_not_installed.prop » ('j') | chrome/test/mini_installer/verifier.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/mini_installer/config/chrome_system_installed.prop

diff --git a/chrome/test/mini_installer/config/chrome_system_installed.prop b/chrome/test/mini_installer/config/chrome_system_installed.prop

index 2a336d90a12b6430e34e27c546b46f1281c1fb79..1339082f1473dc99c2179690cef59a425b7ddd0a 100644

--- a/chrome/test/mini_installer/config/chrome_system_installed.prop

+++ b/chrome/test/mini_installer/config/chrome_system_installed.prop

@@ -25,6 +25,13 @@

"pv": {"type": "SZ", "data": "$MINI_INSTALLER_FILE_VERSION"}

}

+ "HKEY_LOCAL_MACHINE\\$LAUNCHER_UPDATE_REGISTRY_SUBKEY": {

+ "condition": "$SUPPORTS_SXS",

gab 2015/04/08 14:28:29 This is testing only under SxS while the old code

grt (UTC plus 2) 2015/04/08 14:35:40 Not quite. This is testing non-SxS Chrome when SxS

gab 2015/04/08 15:00:58 I see, so this has nothing to do with SxS really..

grt (UTC plus 2) 2015/04/08 15:11:10 Good point. I've made it conditional on Google Chr

+ "exists": "required",

+ "values": {

+ "pv": {"type": "SZ", "data": "$MINI_INSTALLER_FILE_VERSION"}

+ }

+ },

"HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\$CHROME_LONG_NAME": {

"exists": "required",

"values": {