Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: runtime/bin/process_patch.dart

Issue 1068803002: Make the construction of a ProcessResult public (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/process.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_patch.dart
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
index 0cffb5a8c45b1a5250edbcedde6a91386b8acbf4..b6d40ee7a3eea18e8b8ee33fb6c0fd75f008734d 100644
--- a/runtime/bin/process_patch.dart
+++ b/runtime/bin/process_patch.dart
@@ -490,7 +490,7 @@ class _ProcessImpl extends _ProcessImplNativeWrapper with _ServiceObject
_processes.remove(_serviceId);
- return new _ProcessResult(
+ return new ProcessResult(
result[0],
result[1],
getOutput(result[2], stdoutEncoding),
@@ -602,7 +602,7 @@ Future<ProcessResult> _runNonInteractiveProcess(String path,
Future stderr = foldStream(p.stderr, stderrEncoding);
return Future.wait([p.exitCode, stdout, stderr]).then((result) {
- return new _ProcessResult(pid, result[0], result[1], result[2]);
+ return new ProcessResult(pid, result[0], result[1], result[2]);
});
});
}
@@ -625,16 +625,3 @@ ProcessResult _runNonInteractiveProcessSync(
ProcessStartMode.NORMAL);
return process._runAndWait(stdoutEncoding, stderrEncoding);
}
-
-
-class _ProcessResult implements ProcessResult {
- const _ProcessResult(int this.pid,
- int this.exitCode,
- this.stdout,
- this.stderr);
-
- final int pid;
- final int exitCode;
- final stdout;
- final stderr;
-}
« no previous file with comments | « no previous file | sdk/lib/io/process.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698