Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: sdk/lib/io/process.dart

Issue 1068803002: Make the construction of a ProcessResult public (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/process.dart
diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart
index 2d8ecab3bba56e1471548cbce7d1398f65e6c78f..ea1bd76399986540a0d63c19e41a563568eb3ffe 100644
--- a/sdk/lib/io/process.dart
+++ b/sdk/lib/io/process.dart
@@ -431,16 +431,16 @@ abstract class Process {
/**
* [ProcessResult] represents the result of running a non-interactive
- * process started with [:Process.run:].
+ * process started with [Process.run] or [Process.runSync].
*/
-abstract class ProcessResult {
+class ProcessResult {
/**
* Exit code for the process.
*
* See [Process.exitCode] for more information in the exit code
* value.
*/
- int get exitCode;
+ final int exitCode;
/**
* Standard output from the process. The value used for the
@@ -448,7 +448,7 @@ abstract class ProcessResult {
* `null` was used this value is of type `List<int> otherwise it is
* of type `String`.
*/
- get stdout;
+ final stdout;
/**
* Standard error from the process. The value used for the
@@ -456,12 +456,14 @@ abstract class ProcessResult {
* `null` was used this value is of type `List<int>
* otherwise it is of type `String`.
*/
- get stderr;
+ final stderr;
/**
- * Process id from the process.
+ * Process id of the process.
*/
- int get pid;
+ final int pid;
+
+ ProcessResult(this.pid, this.exitCode, this.stdout, this.stderr);
}
« no previous file with comments | « runtime/bin/process_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698